From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253FDC11F69 for ; Wed, 30 Jun 2021 23:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BD3361455 for ; Wed, 30 Jun 2021 23:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232394AbhF3XOS (ORCPT ); Wed, 30 Jun 2021 19:14:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:35638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbhF3XOR (ORCPT ); Wed, 30 Jun 2021 19:14:17 -0400 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23F1761454; Wed, 30 Jun 2021 23:11:47 +0000 (UTC) Date: Wed, 30 Jun 2021 19:11:45 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Paul Burton , linux-kernel@vger.kernel.org, Ingo Molnar , stable@vger.kernel.org Subject: Re: [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT Message-ID: <20210630191145.64f526b0@rorschach.local.home> In-Reply-To: References: <20210630003406.4013668-1-paulburton@google.com> <20210630003406.4013668-2-paulburton@google.com> <20210630083513.1658a6fb@oasis.local.home> <20210630173400.7963f619@oasis.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jun 2021 18:34:11 -0400 Joel Fernandes wrote: > > Anyway, I'll wait to hear what Joel says on this. If he thinks this is > > worth 16M of memory when enabled, I may take it. > > I am not a huge fan of the 16M, in Android we enable this feature on > all devices. Low end Android devices traced in the field are sometimes > 1 GB and the added memory pressure may be unwelcome. Very least, maybe > make it optional only for folks who increase pid_max? Yeah, can we just set it to the size of pid_max, at whatever it is set to? -- Steve