linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, peda@axentia.se, jic23@kernel.org,
	lars@metafoo.de, pmeerw@pmeerw.net
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v3 02/10] iio: inkern: apply consumer scale when no channel scale is available
Date: Wed, 30 Jun 2021 21:00:26 -0400	[thread overview]
Message-ID: <20210701010034.303088-3-liambeguin@gmail.com> (raw)
In-Reply-To: <20210701010034.303088-1-liambeguin@gmail.com>

From: Liam Beguin <lvb@xiphos.com>

When a consumer calls iio_read_channel_processed() and no channel scale
is available, it's assumed that the scale is one and the raw value is
returned as expected.

On the other hand, if the consumer calls iio_convert_raw_to_processed()
the scaling factor requested by the consumer is not applied.

This for example causes the consumer to process mV when expecting uV.
Make sure to always apply the scaling factor requested by the consumer.

Fixes: adc8ec5ff183 ("iio: inkern: pass through raw values if no scaling")
Signed-off-by: Liam Beguin <lvb@xiphos.com>
---
 drivers/iio/inkern.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index b752fe5818e7..b69027690ed5 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -590,10 +590,10 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,
 					IIO_CHAN_INFO_SCALE);
 	if (scale_type < 0) {
 		/*
-		 * Just pass raw values as processed if no scaling is
-		 * available.
+		 * If no channel scaling is available apply consumer scale to
+		 * raw value and return.
 		 */
-		*processed = raw;
+		*processed = raw * scale;
 		return 0;
 	}
 
-- 
2.30.1.489.g328c10930387


  parent reply	other threads:[~2021-07-01  1:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  1:00 [PATCH v3 00/10] iio: afe: add temperature rescaling support Liam Beguin
2021-07-01  1:00 ` [PATCH v3 01/10] iio: inkern: apply consumer scale on IIO_VAL_INT cases Liam Beguin
2021-07-01  1:00 ` Liam Beguin [this message]
2021-07-01  1:00 ` [PATCH v3 03/10] iio: inkern: make a best effort on offset calculation Liam Beguin
2021-07-04 16:26   ` Jonathan Cameron
2021-07-04 18:03     ` Liam Beguin
2021-07-01  1:00 ` [PATCH v3 04/10] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2021-07-04 16:36   ` Jonathan Cameron
2021-07-05  4:23     ` Liam Beguin
2021-07-05  8:29       ` Jonathan Cameron
2021-07-01  1:00 ` [PATCH v3 05/10] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2021-07-04 16:37   ` Jonathan Cameron
2021-07-01  1:00 ` [PATCH v3 06/10] iio: afe: rescale: add offset support Liam Beguin
2021-07-04 16:53   ` Jonathan Cameron
2021-07-05  4:27     ` Liam Beguin
2021-07-01  1:00 ` [PATCH v3 07/10] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2021-07-01  1:00 ` [PATCH v3 08/10] iio: afe: rescale: add temperature transducers Liam Beguin
2021-07-01  1:00 ` [PATCH v3 09/10] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2021-07-04 17:02   ` Jonathan Cameron
2021-07-05  4:31     ` Liam Beguin
2021-07-01  1:00 ` [PATCH v3 10/10] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701010034.303088-3-liambeguin@gmail.com \
    --to=liambeguin@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).