From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38D6C11F69 for ; Thu, 1 Jul 2021 13:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C329613D8 for ; Thu, 1 Jul 2021 13:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232556AbhGAN57 (ORCPT ); Thu, 1 Jul 2021 09:57:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbhGAN56 (ORCPT ); Thu, 1 Jul 2021 09:57:58 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 423CE61350; Thu, 1 Jul 2021 13:55:27 +0000 (UTC) Date: Thu, 1 Jul 2021 09:55:25 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Paul Burton , linux-kernel@vger.kernel.org, Ingo Molnar , stable@vger.kernel.org Subject: Re: [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT Message-ID: <20210701095525.400839d3@oasis.local.home> In-Reply-To: <20210630191145.64f526b0@rorschach.local.home> References: <20210630003406.4013668-1-paulburton@google.com> <20210630003406.4013668-2-paulburton@google.com> <20210630083513.1658a6fb@oasis.local.home> <20210630173400.7963f619@oasis.local.home> <20210630191145.64f526b0@rorschach.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jun 2021 19:11:45 -0400 Steven Rostedt wrote: > On Wed, 30 Jun 2021 18:34:11 -0400 > Joel Fernandes wrote: > > > > Anyway, I'll wait to hear what Joel says on this. If he thinks this is > > > worth 16M of memory when enabled, I may take it. > > > > I am not a huge fan of the 16M, in Android we enable this feature on > > all devices. Low end Android devices traced in the field are sometimes > > 1 GB and the added memory pressure may be unwelcome. Very least, maybe > > make it optional only for folks who increase pid_max? > > Yeah, can we just set it to the size of pid_max, at whatever it is set > to? Can you send a V2 with this update and address Joel's comments to patch 1, and get it to me today? I plan on sending Linus a pull request tomorrow, which means I have to kick off my tests tonight for what I want to send. -- Steve