From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
drinkcat@chromium.org, hsinyi@chromium.org,
Collabora Kernel ML <kernel@collabora.com>,
Bilal Wasim <Bilal.Wasim@imgtec.com>,
linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
Date: Thu, 1 Jul 2021 11:40:22 +0200 [thread overview]
Message-ID: <20210701114012.RESEND.1.I27436c29c3bede46dcf86df696f48683662d1ec1@changeid> (raw)
In-Reply-To: <20210701094024.1273759-1-enric.balletbo@collabora.com>
From: Bilal Wasim <Bilal.Wasim@imgtec.com>
When "bus_prot_reg_update" is true, the driver should use
INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
protection. However, the driver does not use this mask for
clearing bus protection which causes failure when booting
the imgtec gpu.
Corrected and tested with mt8173 chromebook.
Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
index 21a4e113bbec..c5ac649ae51b 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.h
+++ b/drivers/soc/mediatek/mtk-pm-domains.h
@@ -60,7 +60,7 @@
#define BUS_PROT_UPDATE_TOPAXI(_mask) \
BUS_PROT_UPDATE(_mask, \
INFRA_TOPAXI_PROTECTEN, \
- INFRA_TOPAXI_PROTECTEN_CLR, \
+ INFRA_TOPAXI_PROTECTEN, \
INFRA_TOPAXI_PROTECTSTA1)
struct scpsys_bus_prot_data {
--
2.30.2
next prev parent reply other threads:[~2021-07-01 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 9:40 [RESEND PATCH 0/3] Misc bug fixes in mtk power domain driver Enric Balletbo i Serra
2021-07-01 9:40 ` Enric Balletbo i Serra [this message]
2021-07-01 9:40 ` [RESEND PATCH 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD Enric Balletbo i Serra
2021-07-01 9:40 ` [RESEND PATCH 3/3] arm64: dts: mediatek: mt8173: Add domain supply for mfg_async Enric Balletbo i Serra
2021-07-01 17:27 ` [RESEND PATCH 0/3] Misc bug fixes in mtk power domain driver Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701114012.RESEND.1.I27436c29c3bede46dcf86df696f48683662d1ec1@changeid \
--to=enric.balletbo@collabora.com \
--cc=Bilal.Wasim@imgtec.com \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).