From: gushengxian <gushengxian507419@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
gushengxian <gushengxian@yulong.com>
Subject: [PATCH] tools: bpftool: close va_list 'ap' by va_end()
Date: Thu, 1 Jul 2021 05:00:26 -0700 [thread overview]
Message-ID: <20210701120026.709862-1-gushengxian507419@gmail.com> (raw)
From: gushengxian <gushengxian@yulong.com>
va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
tools/bpf/bpftool/jit_disasm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..3c85fd1f00cb 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -45,8 +45,10 @@ static int fprintf_json(void *out, const char *fmt, ...)
char *s;
va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
+ if (vasprintf(&s, fmt, ap) < 0) {
+ va_end(ap);
return -1;
+ }
va_end(ap);
if (!oper_count) {
--
2.25.1
next reply other threads:[~2021-07-01 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 12:00 gushengxian [this message]
2021-07-05 20:58 ` [PATCH] tools: bpftool: close va_list 'ap' by va_end() Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701120026.709862-1-gushengxian507419@gmail.com \
--to=gushengxian507419@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gushengxian@yulong.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).