From: Rob Herring <robh@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: iio: frequency: add adrf6780 doc
Date: Thu, 1 Jul 2021 14:58:19 -0600 [thread overview]
Message-ID: <20210701205819.GA2912677@robh.at.kernel.org> (raw)
In-Reply-To: <20210701141648.131776-1-antoniu.miclaus@analog.com>
On Thu, Jul 01, 2021 at 05:16:48PM +0300, Antoniu Miclaus wrote:
> Add device tree bindings for the ADRF6780 Upconverter.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> v3: remove `adi,parity-en` from example after latest changes in v2
> .../bindings/iio/frequency/adi,adrf6780.yaml | 122 ++++++++++++++++++
> 1 file changed, 122 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,adrf6780.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adrf6780.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adrf6780.yaml
> new file mode 100644
> index 000000000000..b191d98bf778
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adrf6780.yaml
> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/frequency/adi,adrf6780.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADRF6780 Microwave Upconverter
> +
> +maintainers:
> +- Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> + wideband, microwave upconverter optimized for point to point microwave
Wideband
> + radio designs operating in the 5.9 GHz to 23.6 GHz frequency range.
blank line
> + https://www.analog.com/en/products/adrf6780.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adrf6780
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + clocks:
> + description:
> + Definition of the external clock (see clock/clock-bindings.txt)
Drop the reference.
> + minItems: 1
> +
> + clock-names:
> + description:
> + Must be "lo_in"
Looks like a constraint...
clock-names:
items:
- const: lo_in
> + maxItems: 1
> +
> + clock-output-names:
> + maxItems: 1
> +
> + adi,vga-buff-en:
> + description:
> + VGA Buffer Enable.
> + type: boolean
> +
> + adi,lo-buff-en:
> + description:
> + LO Buffer Enable.
> + type: boolean
> +
> + adi,if-mode-en:
> + description:
> + IF Mode Enable.
> + type: boolean
> +
> + adi,iq-mode-en:
> + description:
> + IQ Mode Enable.
> + type: boolean
> +
> + adi,lo-x2-en:
> + description:
> + LO x2 Enable.
> + type: boolean
> +
> + adi,lo-ppf-en:
> + description:
> + LO x1 Enable.
> + type: boolean
> +
> + adi,lo-en:
> + description:
> + LO Enable.
> + type: boolean
Do the other adi,lo-* properties depend on this one? If so, add
'dependencies' schema.
Any other property dependencies or mutual exclusion?
> +
> + adi,uc-bias-en:
> + description:
> + UC Bias Enable.
> + type: boolean
> +
> + adi,lo-sideband:
> + description:
> + Switch to the Other LO Sideband.
> + type: boolean
> +
> + adi,vdet-out-en:
> + description:
> + VDET Output Select Enable.
> + type: boolean
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
No child nodes, what are these for?
> +
> + '#clock-cells':
> + const: 0
> +
> +required:
> +- compatible
> +- reg
> +- clocks
> +- clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +- |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + adrf6780@0{
space ^
> + compatible = "adi,adrf6780";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + clocks = <&adrf6780_lo>;
> + clock-names = "lo_in";
> + };
> + };
> +...
> +
> --
> 2.32.0
>
>
prev parent reply other threads:[~2021-07-01 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 14:16 [PATCH v3] dt-bindings: iio: frequency: add adrf6780 doc Antoniu Miclaus
2021-07-01 20:51 ` Rob Herring
2021-07-01 20:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701205819.GA2912677@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).