From: gushengxian <gushengxian507419@gmail.com>
To: jpoimboe@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, gushengxian <gushengxian@yulong.com>
Subject: [PATCH] objtool: avoid Memory leak: orig_alt_group
Date: Thu, 1 Jul 2021 20:13:27 -0700 [thread overview]
Message-ID: <20210702031327.559429-1-gushengxian507419@gmail.com> (raw)
From: gushengxian <gushengxian@yulong.com>
free(orig_alt_group) should be added in order to avoid memery leak.
Reported by cppcheck.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
tools/objtool/check.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index e5947fbb9e7a..deb48b1bc16d 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1097,6 +1097,7 @@ static int handle_group_alt(struct objtool_file *file,
sizeof(struct cfi_state *));
if (!orig_alt_group->cfi) {
WARN("calloc failed");
+ free(orig_alt_group);
return -1;
}
--
2.25.1
next reply other threads:[~2021-07-02 3:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 3:13 gushengxian [this message]
2021-07-02 8:26 ` [PATCH] objtool: avoid Memory leak: orig_alt_group Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702031327.559429-1-gushengxian507419@gmail.com \
--to=gushengxian507419@gmail.com \
--cc=gushengxian@yulong.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).