linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: '@lunn.ch, Florian Fainelli <f.fainelli@gmail.com>,
	linux-mips@vger.kernel.org, netdev@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Jakub Kicinski <kuba@kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/6] net: dsa: qca: ar9331: add forwarding database support'
Date: Sat, 3 Jul 2021 10:56:44 +0200	[thread overview]
Message-ID: <20210703085644.dg5faj74ijg7orw6@pengutronix.de> (raw)
In-Reply-To: <YN8tWtqfRRO7kAlb@lunn.ch>

On Fri, Jul 02, 2021 at 05:14:34PM +0200, Andrew Lunn wrote:
> On Fri, Jul 02, 2021 at 12:17:48PM +0200, Oleksij Rempel wrote:
> > This switch provides simple address resolution table, without VLAN or
> > multicast specific information.
> > With this patch we are able now to read, modify unicast and mulicast
> 
> mul_t_icast.

done

> > addresses.
> > +static int ar9331_sw_port_fdb_dump(struct dsa_switch *ds, int port,
> > +				   dsa_fdb_dump_cb_t *cb, void *data)
> > +{
> > +	struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv;
> > +	int cnt = AR9331_SW_NUM_ARL_RECORDS;
> > +	struct ar9331_sw_fdb _fdb = { 0 };
> 
> Why use _fdb? There does not appear to be an fdb?

old artifact, renamed.

> > +static int ar9331_sw_port_fdb_rmw(struct ar9331_sw_priv *priv,
> > +				  const unsigned char *mac,
> > +				  u8 port_mask_set,
> > +				  u8 port_mask_clr)
> > +{
> > +	struct regmap *regmap = priv->regmap;
> > +	u32 f0, f1, f2 = 0;
> > +	u8 port_mask, port_mask_new, status, func;
> > +	int ret;
> 
> Reverse Christmas tree.

done

> > +static int ar9331_sw_port_fdb_add(struct dsa_switch *ds, int port,
> > +				  const unsigned char *mac, u16 vid)
> > +{
> > +	struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv;
> > +	u16 port_mask = BIT(port);
> > +
> > +	dev_info(priv->dev, "%s(%pM, %x)\n", __func__, mac, port);
> 
> dev_dbg()?

removed.

Thank you!
Can I have your Reviewed-by with this changes?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2021-07-03  8:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 10:17 [PATCH net-next v2 0/6] ar9331: mainline some parts of switch functionality Oleksij Rempel
2021-07-02 10:17 ` [PATCH net-next v2 1/6] net: dsa: qca: ar9331: reorder MDIO write sequence Oleksij Rempel
2021-07-02 10:17 ` [PATCH net-next v2 2/6] net: dsa: qca: ar9331: make proper initial port defaults Oleksij Rempel
2021-07-02 15:06   ` Andrew Lunn
2021-07-02 10:17 ` [PATCH net-next v2 3/6] net: dsa: qca: ar9331: add forwarding database support Oleksij Rempel
2021-07-02 15:14   ` [PATCH net-next v2 3/6] net: dsa: qca: ar9331: add forwarding database support' Andrew Lunn
2021-07-03  8:56     ` Oleksij Rempel [this message]
2021-07-03 14:33       ` Andrew Lunn
2021-07-02 10:17 ` [PATCH net-next v2 4/6] net: dsa: qca: ar9331: add ageing time support Oleksij Rempel
2021-07-02 10:17 ` [PATCH net-next v2 5/6] net: dsa: qca: ar9331: add bridge support Oleksij Rempel
2021-07-02 10:17 ` [PATCH net-next v2 6/6] net: dsa: qca: ar9331: add vlan support Oleksij Rempel
2021-07-02 20:38 ` [PATCH net-next v2 0/6] ar9331: mainline some parts of switch functionality David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210703085644.dg5faj74ijg7orw6@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc='@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).