linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: tj@kernel.org, shuah@kernel.org, akpm@linux-foundation.org,
	Richard Fontana <fontana@sharpeleven.org>,
	rafael@kernel.org, davem@davemloft.net, kuba@kernel.org,
	ast@kernel.org, andriin@fb.com, daniel@iogearbox.net,
	atenart@kernel.org, alobakin@pm.me, weiwan@google.com,
	ap420073@gmail.com, jeyu@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, minchan@kernel.org,
	axboe@kernel.dk, mbenes@suse.com, jpoimboe@redhat.com,
	tglx@linutronix.de, keescook@chromium.org, jikos@kernel.org,
	rostedt@goodmis.org, peterz@infradead.org,
	linux-block@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] selftests: add tests_sysfs module
Date: Sat, 3 Jul 2021 08:52:03 -0700	[thread overview]
Message-ID: <20210703155203.uvxcolrddswecco6@garbanzo> (raw)
In-Reply-To: <YN/rtmZbd6velB1L@kroah.com>

On Sat, Jul 03, 2021 at 06:46:46AM +0200, Greg KH wrote:
> On Fri, Jul 02, 2021 at 12:02:30PM -0700, Luis Chamberlain wrote:
> > On Fri, Jul 02, 2021 at 07:21:12AM +0200, Greg KH wrote:
> > > On Thu, Jul 01, 2021 at 10:05:40PM -0700, Luis Chamberlain wrote:
> > > > @@ -0,0 +1,953 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-or-later
> > > > +/*
> > > > + * sysfs test driver
> > > > + *
> > > > + * Copyright (C) 2021 Luis Chamberlain <mcgrof@kernel.org>
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or modify it
> > > > + * under the terms of the GNU General Public License as published by the Free
> > > > + * Software Foundation; either version 2 of the License, or at your option any
> > > > + * later version; or, when distributed separately from the Linux kernel or
> > > > + * when incorporated into other software packages, subject to the following
> > > > + * license:
> > > 
> > > This boilerplate should not be here, only the spdx line is needed.
> > 
> > As per Documentation/process/license-rules.rst we use the SPDX license
> > tag for the license that applies but it also states about dual
> > licensing:
> > 
> > "Aside from that, individual files can be provided under a dual license,         
> > e.g. one of the compatible GPL variants and alternatively under a               
> > permissive license like BSD, MIT etc."
> > 
> > Let me know if things should change somehow here to clarify this better.
> 
> The spdx line is not matching the actual license for the file, which is
> wrong.

We don't have spdx license tag yet for copyleft-next, and although
when using dual gplv2 or copyleft-next gplv2 applies I did fail to see
can use spdx for dual licensing such as:

# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause

> And "copyright-left" is not a valid license according to our list of
> valid licenses in the LICENSES directory, so please do not add it to
> kernel code when it is obviously not needed.

You mean copyleft-next. Yes I'd have to add that. Given that we already
have two test drivers with that license I'll go ahead and add that.

> And given that this is directly interacting with sysfs, which is
> GPLv2-only, trying to claim a different license on the code that tests
> it is going to be a total mess for any lawyer who wants to look into
> this.  Just keep it simple please.

The faul injection code I added follows the exact license for sysfs. The
only interaction with the test_sysfs and sysfs is an exported symbol
for a completion structure. The other dual gpl OR copyleft-next test
drivers already present in the kernel also use exported symbols too, so
I see nothing new here.

  Luis

  reply	other threads:[~2021-07-03 15:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  5:05 [PATCH 0/4] selftests: add a new test driver for sysfs Luis Chamberlain
2021-07-02  5:05 ` [PATCH 1/4] selftests: add tests_sysfs module Luis Chamberlain
2021-07-02  5:21   ` Greg KH
2021-07-02 19:02     ` Luis Chamberlain
2021-07-03  4:46       ` Greg KH
2021-07-03 15:52         ` Luis Chamberlain [this message]
2021-07-04 20:26           ` Richard Fontana
2021-07-02  5:05 ` [PATCH 2/4] kernfs: add initial failure injection support Luis Chamberlain
2021-07-02  5:05 ` [PATCH 3/4] test_sysfs: add support to use kernfs failure injection Luis Chamberlain
2021-07-02  5:05 ` [PATCH 4/4] test_sysfs: demonstrate deadlock fix Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210703155203.uvxcolrddswecco6@garbanzo \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alobakin@pm.me \
    --cc=andriin@fb.com \
    --cc=ap420073@gmail.com \
    --cc=ast@kernel.org \
    --cc=atenart@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=fontana@sharpeleven.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mbenes@suse.com \
    --cc=minchan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).