From: Viresh Kumar <viresh.kumar@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jie Deng <jie.deng@intel.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Jason Wang <jasowang@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com,
Stefan Hajnoczi <stefanha@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v13] i2c: virtio: add a virtio i2c frontend driver
Date: Mon, 5 Jul 2021 14:26:10 +0530 [thread overview]
Message-ID: <20210705085610.okcvnhwhwehjiehy@vireshk-i7> (raw)
In-Reply-To: <CAHp75Vf0_8+KW_cp2g0V1miMx1cegBdjLzBjTbtpmcmdCHQJxA@mail.gmail.com>
On 05-07-21, 11:45, Andy Shevchenko wrote:
> On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 05-07-21, 14:53, Jie Deng wrote:
>
> > > +#include <linux/types.h>
> > > +#include <linux/const.h>
> >
> > Both of these need to be the uapi headers as Andy said earlier
>
> They are already since this header _is_ UAPI,
Ahh, there is some tricky header inclusion there :)
> what you are suggesting is gonna not work,
Why ?
> although it's correct for in-kernel users of UAPI
> headers.
--
viresh
next prev parent reply other threads:[~2021-07-05 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 6:53 [PATCH v13] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-07-05 8:02 ` Viresh Kumar
2021-07-05 8:45 ` Andy Shevchenko
2021-07-05 8:56 ` Viresh Kumar [this message]
2021-07-05 9:38 ` Andy Shevchenko
2021-07-05 9:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705085610.okcvnhwhwehjiehy@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=conghui.chen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jie.deng@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=shuo.a.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).