From: Andreas Kemnade <andreas@kemnade.info>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jonathan Cameron <jic23@kernel.org>, <robh+dt@kernel.org>,
<lars@metafoo.de>, <sre@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <leonard.crestez@nxp.com>,
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH 2/4] mfd: rn5t618: Add of compatibles for ADC and power
Date: Mon, 5 Jul 2021 12:03:58 +0200 [thread overview]
Message-ID: <20210705120358.6bf737f7@aktux> (raw)
In-Reply-To: <20210705093129.00005aab@Huawei.com>
On Mon, 5 Jul 2021 09:31:29 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Mon, 5 Jul 2021 08:36:08 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Sat, 03 Jul 2021, Jonathan Cameron wrote:
> >
> > > On Sat, 3 Jul 2021 10:42:22 +0200
> > > Andreas Kemnade <andreas@kemnade.info> wrote:
> > >
> > > > This allows having devicetree nodes for the subdevices.
> > > >
> > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > ---
> > > > drivers/mfd/rn5t618.c | 6 ++++--
> > > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
> > > > index 384acb459427..b916c7471ca3 100644
> > > > --- a/drivers/mfd/rn5t618.c
> > > > +++ b/drivers/mfd/rn5t618.c
> > > > @@ -24,8 +24,10 @@ static const struct mfd_cell rn5t618_cells[] = {
> > > > };
> > > >
> > > > static const struct mfd_cell rc5t619_cells[] = {
> > > > - { .name = "rn5t618-adc" },
> > > > - { .name = "rn5t618-power" },
> > > > + { .name = "rn5t618-adc",
> > > > + .of_compatible = "ricoh,rc5t619-adc" },
> > >
> > > Odd to have a name of 618 and a compatible of 619. Why?
> > > Definitely deserves a comment if this is necessary for some reason!
> >
> > Actually this is the norm. We have lots of drivers named after the
> > *first* device they supported before expansion.
>
> Ah. I'd missed that this cells array is specific to the 5t619, though if
> the driver is the same I'd also expect it to be needed for the 5t618 entry.
>
Well, yes, it is needed for the 5t618 also. But if I would add it, it
would be untested. And that second shorter array is also used for the
rn5t567 which does not have an ADC, So I we need three arrays there.
Regards,
Andreas
next prev parent reply other threads:[~2021-07-05 10:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 8:42 [PATCH 0/4] mfd: rn5t618: Extend ADC support Andreas Kemnade
2021-07-03 8:42 ` [PATCH 1/4] dt-bindings: mfd: ricoh,rn5t618: ADC related nodes and properties Andreas Kemnade
2021-07-03 16:02 ` Jonathan Cameron
2021-07-03 16:43 ` Andreas Kemnade
2021-07-12 14:41 ` Rob Herring
2021-07-03 8:42 ` [PATCH 2/4] mfd: rn5t618: Add of compatibles for ADC and power Andreas Kemnade
2021-07-03 16:04 ` Jonathan Cameron
2021-07-03 16:31 ` Andreas Kemnade
2021-07-04 16:17 ` Jonathan Cameron
2021-07-05 7:36 ` Lee Jones
2021-07-05 8:31 ` Jonathan Cameron
2021-07-05 10:03 ` Andreas Kemnade [this message]
2021-07-05 7:37 ` Lee Jones
2021-07-03 8:42 ` [PATCH 3/4] iio: rn5t618: Add devicetree support Andreas Kemnade
2021-07-03 16:12 ` Jonathan Cameron
2021-07-03 8:42 ` [PATCH 4/4] power: supply: rn5t618: Add voltage_now property Andreas Kemnade
2021-07-03 11:41 ` kernel test robot
2021-07-03 14:35 ` kernel test robot
2021-07-03 15:29 ` Andreas Kemnade
2021-07-03 16:12 ` Jonathan Cameron
2021-07-03 15:59 ` [PATCH 0/4] mfd: rn5t618: Extend ADC support Jonathan Cameron
2021-07-03 16:39 ` Andreas Kemnade
2021-07-03 16:55 ` [Letux-kernel] " Andreas Kemnade
2021-07-04 16:10 ` Jonathan Cameron
2021-07-05 11:18 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705120358.6bf737f7@aktux \
--to=andreas@kemnade.info \
--cc=Jonathan.Cameron@Huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).