linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	Marek Vasut <marex@denx.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: rawnand: denali: add more delays before latching incoming data
Date: Mon, 5 Jul 2021 10:48:23 -0400	[thread overview]
Message-ID: <20210705144823.GA1459782@maple.netwinder.org> (raw)
In-Reply-To: <CAK7LNASvYVyEQ4M_zEUdw9K9AB-RVErKoqFMQZ5OSKJF0AoBww@mail.gmail.com>

On Mon, Jul 05, 2021 at 01:00:43AM +0900, Masahiro Yamada wrote:
>
>I no longer have any hardware to test this driver.
>
>If you increase data_setup_on_host (the current value is 10000),
>will it solve your issue?

Yes, it does seem to work with this value increased to 10001.

Looking more closely, I compared timing parameters in struct 
denali_chip_sel, for the kernel 5.4 (which works), for 5.10 (which 
fails), and also for 5.10 with data_setup_host=10001 (which works).

                 5.4     5.10    5.10+10001
acc_clks        2       3       4
rdwr_en_lo_cnt  3       2       3
cs_setup_cnt    1       0       0

So it seems that on my hardware, rdwr_en_lo_cnt must be >= 3.

Regards,
Ralph

      reply	other threads:[~2021-07-05 14:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17  7:18 [PATCH v2] mtd: rawnand: denali: add more delays before latching incoming data Masahiro Yamada
2020-04-22 15:29 ` Marek Vasut
2020-04-22 15:36   ` Miquel Raynal
2020-04-22 15:37     ` Marek Vasut
2020-05-10 20:06 ` Miquel Raynal
2021-06-30 18:47 ` Ralph Siemsen
2021-07-04 16:00   ` Masahiro Yamada
2021-07-05 14:48     ` Ralph Siemsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210705144823.GA1459782@maple.netwinder.org \
    --to=ralph.siemsen@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=masahiroy@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).