From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Paul Cercueil <paul@crapouillou.net>,
Alexander Lobakin <alobakin@pm.me>,
Xingxing Su <suxingxing@loongson.cn>,
zhaoxiao <zhaoxiao@uniontech.com>,
Huacai Chen <chenhuacai@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>, Alban Bedel <albeu@free.fr>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: always link byteswap helpers into decompressor
Date: Mon, 5 Jul 2021 17:08:23 +0200 [thread overview]
Message-ID: <20210705150823.GA12584@alpha.franken.de> (raw)
In-Reply-To: <20210702142919.392532-1-arnd@kernel.org>
On Fri, Jul 02, 2021 at 04:28:37PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> My series to clean up the unaligned access implementation
> across architectures caused some mips randconfig builds to
> fail with:
>
> mips64-linux-ld: arch/mips/boot/compressed/decompress.o: in function `decompress_kernel':
> decompress.c:(.text.decompress_kernel+0x54): undefined reference to `__bswapsi2'
>
> It turns out that this problem has already been fixed for the XZ
> decompressor but now it also shows up in (at least) LZO and LZ4. From my
> analysis I concluded that the compiler could always have emitted those
> calls, but the different implementation allowed it to make otherwise
> better decisions about not inlining the byteswap, which results in the
> link error when the out-of-line code is missing.
>
> While it could be addressed by adding it to the two decompressor
> implementations that are known to be affected, but as this only adds
> 112 bytes to the kernel, the safer choice is to always add them.
>
> Fixes: c50ec6787536 ("MIPS: zboot: Fix the build with XZ compression on older GCC versions")
> Fixes: 0652035a5794 ("asm-generic: unaligned: remove byteshift helpers")
> Link: https://lore.kernel.org/linux-mm/202106301304.gz2wVY9w-lkp@intel.com/
> Link: https://lore.kernel.org/linux-mm/202106260659.TyMe8mjr-lkp@intel.com/
> Link: https://lore.kernel.org/linux-mm/202106172016.onWT6Tza-lkp@intel.com/
> Link: https://lore.kernel.org/linux-mm/202105231743.JJcALnhS-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/mips/boot/compressed/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied to mips-next (for second pull request).
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-07-05 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 14:28 [PATCH] mips: always link byteswap helpers into decompressor Arnd Bergmann
2021-07-05 15:08 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705150823.GA12584@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=albeu@free.fr \
--cc=alobakin@pm.me \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=suxingxing@loongson.cn \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).