From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC02C07E99 for ; Mon, 5 Jul 2021 10:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE636613D1 for ; Mon, 5 Jul 2021 10:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbhGEKIk (ORCPT ); Mon, 5 Jul 2021 06:08:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230450AbhGEKIg (ORCPT ); Mon, 5 Jul 2021 06:08:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15B32613C1; Mon, 5 Jul 2021 10:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625479559; bh=clEEcgpo77QbxqDt1/fBWykvR1xsS7DG0yP3rdAU9PY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fLaUWjUYTr+Z3zSFPGeZb8zhTkaPYVxEbjpFL1yX2V+VJErywpmKzASeDT3UCaJQe Hum163aD6NfubuujXBh2f4XHDrv3MmJr41yfmcRqj3uK+Ykg9O17//M8fz2fXxaWvB 2j5zwCN/nQii0pPLPa173SYTUBf7m7v9MVUNT5WdDgo0xz6oZLf+rPH+M8qYOMCxaR gXY4AG1ibb3K3IUP3Y+qmOg9YwI0QQY6kgPeKjNOxAOYieih64UFN5FMvPJhO19YaH Lb+qrZ2ozf/zOgAvQFIa1ACdiafC4Ots4TgVpP0vhVx6AyR6wJEtvVDCEAezXVaBAk Lyo2cQBrh42mA== Date: Mon, 5 Jul 2021 19:05:55 +0900 From: Masami Hiramatsu To: Ingo Molnar Cc: Steven Rostedt , Josh Poimboeuf , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko Subject: Re: [PATCH -tip v8 01/13] ia64: kprobes: Fix to pass correct trampoline address to the handler Message-Id: <20210705190555.7c02f53dc92a6a3191a17fb1@kernel.org> In-Reply-To: References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399993125.506599.11062077324255866677.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jul 2021 09:46:33 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Commit e792ff804f49 ("ia64: kprobes: Use generic kretprobe trampoline handler") > > missed to pass the wrong trampoline address (it passes the descriptor address > > instead of function entry address). > > This fixes it to pass correct trampoline address to __kretprobe_trampoline_handler(). > > This also changes to use correct symbol dereference function to get the > > function address from the kretprobe_trampoline. > > > > Fixes: e792ff804f49 ("ia64: kprobes: Use generic kretprobe trampoline handler") > > Signed-off-by: Masami Hiramatsu > > A better changelog: > > The following commit: > > Commit e792ff804f49 ("ia64: kprobes: Use generic kretprobe trampoline handler") > > Passed the wrong trampoline address to __kretprobe_trampoline_handler(): it > passes the descriptor address instead of function entry address. > > Pass the right parameter. > > Also use correct symbol dereference function to get the function address > from 'kretprobe_trampoline' - an IA64 special. Thanks for rewriting! OK, I'll update it. > > (Although I realize that much of this goes away just a couple of patches > later.) Yes, but since this is a real bug. I think I should split it for backporting to stable trees. (Oh, I also forgot to add Cc: stable. Sorry about that.) Thank you, -- Masami Hiramatsu