Re: [PATCH v9 8/8] PCI: Change the type of probe argument in reset functions

From: kernel test robot <lkp@intel.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: kbuild-all@lists.01.org, alex.williamson@redhat.com,
	Raphael Norwitz <raphael.norwitz@nutanix.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	kw@linux.com, Shanker Donthineni <sdonthineni@nvidia.com>,
	Sinan Kaya <okaya@kernel.org>, Len Brown <lenb@kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v9 8/8] PCI: Change the type of probe argument in reset functions
Date: Tue, 6 Jul 2021 07:39:55 +0800	[thread overview]
Message-ID: <202107060748.80eoT31Q-lkp@intel.com> (raw)
In-Reply-To: <20210705142138.2651-9-ameynarkhede03@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3061 bytes --]

Hi Amey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[cannot apply to pm/linux-next cryptodev/master crypto/master linus/master v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amey-Narkhede/Expose-and-manage-PCI-device-reset/20210705-222358
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4866dd22881441f63dc57f682b3acbc539c83fe2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Amey-Narkhede/Expose-and-manage-PCI-device-reset/20210705-222358
        git checkout 4866dd22881441f63dc57f682b3acbc539c83fe2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/pci/hotplug/pnv_php.c:603:17: error: initialization of 'int (*)(struct hotplug_slot *, pci_reset_mode_t)' {aka 'int (*)(struct hotplug_slot *, enum pci_reset_mode)'} from incompatible pointer type 'int (*)(struct hotplug_slot *, int)' [-Werror=incompatible-pointer-types]
     603 |  .reset_slot  = pnv_php_reset_slot,
         |                 ^~~~~~~~~~~~~~~~~~
   drivers/pci/hotplug/pnv_php.c:603:17: note: (near initialization for 'php_slot_ops.reset_slot')
   cc1: some warnings being treated as errors

vim +603 drivers/pci/hotplug/pnv_php.c

66725152fb9f17 Gavin Shan        2016-05-20  595  
81c4b5bf30de01 Lukas Wunner      2018-09-08  596  static const struct hotplug_slot_ops php_slot_ops = {
66725152fb9f17 Gavin Shan        2016-05-20  597  	.get_power_status	= pnv_php_get_power_state,
66725152fb9f17 Gavin Shan        2016-05-20  598  	.get_adapter_status	= pnv_php_get_adapter_state,
a7da21613c4efc Lukas Wunner      2018-09-08  599  	.get_attention_status	= pnv_php_get_attention_state,
66725152fb9f17 Gavin Shan        2016-05-20  600  	.set_attention_status	= pnv_php_set_attention_state,
66725152fb9f17 Gavin Shan        2016-05-20  601  	.enable_slot		= pnv_php_enable_slot,
66725152fb9f17 Gavin Shan        2016-05-20  602  	.disable_slot		= pnv_php_disable_slot,
7fd1fe4e4811f5 Oliver O'Halloran 2019-09-03 @603  	.reset_slot		= pnv_php_reset_slot,
66725152fb9f17 Gavin Shan        2016-05-20  604  };
66725152fb9f17 Gavin Shan        2016-05-20  605  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73386 bytes --]