From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E82AC07E96 for ; Tue, 6 Jul 2021 12:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E475621D2 for ; Tue, 6 Jul 2021 12:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231809AbhGFMQl (ORCPT ); Tue, 6 Jul 2021 08:16:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:47598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237043AbhGFLfw (ORCPT ); Tue, 6 Jul 2021 07:35:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E27661CAB; Tue, 6 Jul 2021 11:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570717; bh=D0aqLcDHnyIhmX9cVux80w3kOxWK9bN3LSxoqo//I1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dlgd3e8cXxKAh/DcSldA6/q/BirDY4z/bbcH035wplHVYwY/HyryUEdPNeLEctLno Z1JIsU7kDNr5SAIytGS7QuzEsJVusFzZ/m8cSNrDaeij+QPKQPJ+xUaJUvGjf24+F1 wh309Vb/T8YxI7GOSMnPIUdg/u+K7bP+WvUv6NO7kahEBgmHHFlzCR6GEF6IcfS+dG MwVXu1HQUbX/NWzhf1HajzgU3Cbz1pZw2buUWqgU7oOS69eJszud1kW9bjW+UJWfQE ZtcsP81t9o0X91RhhnylmdD5fpFfUQ8PXdUsd3R207kzaoyg1qhQDZb6nfO1yzDQWT XMaya/b7wsp8A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zou Wei , Hulk Robot , "David S . Miller" , Sasha Levin , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 11/74] atm: nicstar: Fix possible use-after-free in nicstar_cleanup() Date: Tue, 6 Jul 2021 07:23:59 -0400 Message-Id: <20210706112502.2064236-11-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706112502.2064236-1-sashal@kernel.org> References: <20210706112502.2064236-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zou Wei [ Upstream commit 34e7434ba4e97f4b85c1423a59b2922ba7dff2ea ] This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Zou Wei Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/nicstar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index bb9835c62641..5ec7b6a60145 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -297,7 +297,7 @@ static void __exit nicstar_cleanup(void) { XPRINTK("nicstar: nicstar_cleanup() called.\n"); - del_timer(&ns_timer); + del_timer_sync(&ns_timer); pci_unregister_driver(&nicstar_driver); -- 2.30.2