From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DD9C11F7D for ; Tue, 6 Jul 2021 12:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2872C620DC for ; Tue, 6 Jul 2021 12:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243144AbhGFMDT (ORCPT ); Tue, 6 Jul 2021 08:03:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:47572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237337AbhGFLgF (ORCPT ); Tue, 6 Jul 2021 07:36:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA09B61C7C; Tue, 6 Jul 2021 11:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570817; bh=h6aqlsDftzHhM8owYXhjemIwdd1TORNGq9b2mpINls0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NG3Rzo4Txcnc9MysHTedjUQpYAMxebrFjPSYnq0ZzdGQ4U//+wT/WLyDwOXCYjWMu wOcBJvaA08AjoYDuf/8WYk07YljOJ5XrrwodWGsxnWuGDVpdu++sx0WkbBMs4vIbQC jStcvPvE38UWQVDaKmQTwkAQROpfu5JjlxiiH2OdtpVh4ecptpxdDMh0V90YgwrMGE ArBxfP2TKWFXD24jECkzfXvfQl8S/1EJvXga942i7Tsdt2poOynSP76zNRoSg1EhYg vHZNAhp7u97mmgbu66KFq1M7OdIbCHFwluxT2gzh4rRHiJnB84RBtbJfzbcStk91gz 1uj4SO/29aF5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xie Yongji , Gerd Hoffmann , Sasha Levin , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: [PATCH AUTOSEL 4.19 14/55] drm/virtio: Fix double free on probe failure Date: Tue, 6 Jul 2021 07:25:57 -0400 Message-Id: <20210706112638.2065023-14-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706112638.2065023-1-sashal@kernel.org> References: <20210706112638.2065023-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie Yongji [ Upstream commit cec7f1774605a5ef47c134af62afe7c75c30b0ee ] The virtio_gpu_init() will free vgdev and vgdev->vbufs on failure. But such failure will be caught by virtio_gpu_probe() and then virtio_gpu_release() will be called to do some cleanup which will free vgdev and vgdev->vbufs again. So let's set dev->dev_private to NULL to avoid double free. Signed-off-by: Xie Yongji Link: http://patchwork.freedesktop.org/patch/msgid/20210517084913.403-2-xieyongji@bytedance.com Signed-off-by: Gerd Hoffmann Signed-off-by: Sasha Levin --- drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c index 2cfd0016bd70..7e0092fd0703 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -237,6 +237,7 @@ int virtio_gpu_driver_load(struct drm_device *dev, unsigned long flags) err_vbufs: vgdev->vdev->config->del_vqs(vgdev->vdev); err_vqs: + dev->dev_private = NULL; kfree(vgdev); return ret; } -- 2.30.2