From: Stefano Garzarella <sgarzare@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Jason Wang <jasowang@redhat.com>,
Yunsheng Lin <linyunsheng@huawei.com>
Subject: Re: [PATCH 2/2] vringh: Include spinlock.h
Date: Tue, 6 Jul 2021 16:44:25 +0200 [thread overview]
Message-ID: <20210706144425.cp3yzdinmosqftjr@steredhat> (raw)
In-Reply-To: <20210706142632.670483-3-eperezma@redhat.com>
On Tue, Jul 06, 2021 at 04:26:32PM +0200, Eugenio Pérez wrote:
>Commit f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb
>accesses") introduces this dependency, but does not include spinlock.h.
>While kernel seems to compile as usual, tools/virtio cannot do the
>same.
>
>Fixes: f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb accesses")
>
>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> include/linux/vringh.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/linux/vringh.h b/include/linux/vringh.h
>index 84db7b8f912f..212892cf9822 100644
>--- a/include/linux/vringh.h
>+++ b/include/linux/vringh.h
>@@ -14,6 +14,7 @@
> #include <linux/virtio_byteorder.h>
> #include <linux/uio.h>
> #include <linux/slab.h>
>+#include <linux/spinlock.h>
> #if IS_REACHABLE(CONFIG_VHOST_IOTLB)
> #include <linux/dma-direction.h>
> #include <linux/vhost_iotlb.h>
>--
>2.27.0
>
Ooops, thanks for fixing this!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2021-07-06 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 14:26 [PATCH 0/2] tools/virtio: fix compilation Eugenio Pérez
2021-07-06 14:26 ` [PATCH 1/2] tools: Remove lockdep.h and its include from spinlock.h Eugenio Pérez
2021-07-06 14:32 ` Matthew Wilcox
2021-07-06 14:26 ` [PATCH 2/2] vringh: Include spinlock.h Eugenio Pérez
2021-07-06 14:44 ` Stefano Garzarella [this message]
2021-07-07 3:18 ` [PATCH 0/2] tools/virtio: fix compilation Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706144425.cp3yzdinmosqftjr@steredhat \
--to=sgarzare@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mst@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).