* [PATCH 1/2] iomap: Remove length variable in iomap_seek_data()
@ 2021-07-06 16:31 Matthew Wilcox (Oracle)
2021-07-06 16:31 ` [PATCH 2/2] iomap: Remove length variable in iomap_seek_hole() Matthew Wilcox (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox (Oracle) @ 2021-07-06 16:31 UTC (permalink / raw)
To: linux-fsdevel, linux-xfs, Darrick J. Wong, Christoph Hellwig,
linux-kernel
Cc: Matthew Wilcox (Oracle), Christoph Hellwig, Zhen Lei
There's no need to calculate and maintain 'length'. It's shorter and
simpler code to just calculate size - offset each time around the loop.
Suggested-by: Christoph Hellwig <hch@lst.de>
Reported-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/iomap/seek.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
index dab1b02eba5b..241169b49af8 100644
--- a/fs/iomap/seek.c
+++ b/fs/iomap/seek.c
@@ -83,27 +83,23 @@ loff_t
iomap_seek_data(struct inode *inode, loff_t offset, const struct iomap_ops *ops)
{
loff_t size = i_size_read(inode);
- loff_t length = size - offset;
loff_t ret;
/* Nothing to be found before or beyond the end of the file. */
if (offset < 0 || offset >= size)
return -ENXIO;
- while (length > 0) {
- ret = iomap_apply(inode, offset, length, IOMAP_REPORT, ops,
- &offset, iomap_seek_data_actor);
+ while (offset < size) {
+ ret = iomap_apply(inode, offset, size - offset, IOMAP_REPORT,
+ ops, &offset, iomap_seek_data_actor);
if (ret < 0)
return ret;
if (ret == 0)
- break;
+ return offset;
offset += ret;
- length -= ret;
}
- if (length <= 0)
- return -ENXIO;
- return offset;
+ return -ENXIO;
}
EXPORT_SYMBOL_GPL(iomap_seek_data);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] iomap: Remove length variable in iomap_seek_hole()
2021-07-06 16:31 [PATCH 1/2] iomap: Remove length variable in iomap_seek_data() Matthew Wilcox (Oracle)
@ 2021-07-06 16:31 ` Matthew Wilcox (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox (Oracle) @ 2021-07-06 16:31 UTC (permalink / raw)
To: linux-fsdevel, linux-xfs, Darrick J. Wong, Christoph Hellwig,
linux-kernel
Cc: Matthew Wilcox (Oracle), Christoph Hellwig, Zhen Lei
There's no need to calculate and maintain 'length'. It's shorter and
simpler code to just calculate size - offset each time around the loop.
Suggested-by: Christoph Hellwig <hch@lst.de>
Reported-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/iomap/seek.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
index 241169b49af8..4f711e1269e0 100644
--- a/fs/iomap/seek.c
+++ b/fs/iomap/seek.c
@@ -35,23 +35,21 @@ loff_t
iomap_seek_hole(struct inode *inode, loff_t offset, const struct iomap_ops *ops)
{
loff_t size = i_size_read(inode);
- loff_t length = size - offset;
loff_t ret;
/* Nothing to be found before or beyond the end of the file. */
if (offset < 0 || offset >= size)
return -ENXIO;
- while (length > 0) {
- ret = iomap_apply(inode, offset, length, IOMAP_REPORT, ops,
- &offset, iomap_seek_hole_actor);
+ while (offset < size) {
+ ret = iomap_apply(inode, offset, size - offset, IOMAP_REPORT,
+ ops, &offset, iomap_seek_hole_actor);
if (ret < 0)
return ret;
if (ret == 0)
break;
offset += ret;
- length -= ret;
}
return offset;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-06 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 16:31 [PATCH 1/2] iomap: Remove length variable in iomap_seek_data() Matthew Wilcox (Oracle)
2021-07-06 16:31 ` [PATCH 2/2] iomap: Remove length variable in iomap_seek_hole() Matthew Wilcox (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).