From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH v2] tracing: Add linear buckets to histogram logic
Date: Tue, 6 Jul 2021 20:35:44 -0400 [thread overview]
Message-ID: <20210706203544.6ef9a04e@rorschach.local.home> (raw)
In-Reply-To: <ed01dc3a4219611316e3e08756553dce415c2edc.camel@kernel.org>
On Tue, 06 Jul 2021 17:09:24 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -120,6 +120,7 @@ struct hist_field {
> > unsigned int size;
> > unsigned int offset;
> > unsigned int is_signed;
> > + unsigned long grouping;
>
> Just wondering if it would be more consistent to name this 'buckets' or
> even 'bucket_size'.
I originally did change it to that, but thought against it. I guess I
could change that.
Thanks!
-- Steve
>
> > const char *type;
> > struct hist_field *operands[HIST_FIELD_OPERANDS_MAX];
> > struct hist_trigger_data *hist_data;
> > @@ -218,6 +219,27 @@ static u64 hist_field_log2(struct hist_field
> > *hist_field,
> > return (u64) ilog2(roundup_pow_of_two(val));
> > }
> >
next prev parent reply other threads:[~2021-07-07 0:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210706154315.3567166e@gandalf.local.home>
2021-07-06 22:09 ` [PATCH v2] tracing: Add linear buckets to histogram logic Tom Zanussi
2021-07-07 0:35 ` Steven Rostedt [this message]
2021-07-06 23:20 ` Namhyung Kim
2021-07-07 0:50 ` Steven Rostedt
2021-07-07 14:00 ` Namhyung Kim
2021-07-07 15:11 ` Steven Rostedt
2021-07-07 15:18 ` Tom Zanussi
[not found] ` <20210707195851.ae0aa69f0d37ed6d91c68e06@kernel.org>
2021-07-07 13:44 ` Steven Rostedt
2021-07-07 18:26 ` Steven Rostedt
2021-07-07 18:28 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706203544.6ef9a04e@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).