From: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
To: jlayton@kernel.org, bfields@fieldses.org, viro@zeniv.linux.org.uk
Cc: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2 0/2] fcntl: fix potential deadlocks
Date: Wed, 7 Jul 2021 10:35:46 +0800 [thread overview]
Message-ID: <20210707023548.15872-1-desmondcheongzx@gmail.com> (raw)
Hi,
Sorry for the delay between v1 and v2, there was an unrelated issue with Syzbot testing.
Syzbot reports a possible irq lock inversion dependency:
https://syzkaller.appspot.com/bug?id=923cfc6c6348963f99886a0176ef11dcc429547b
While investigating this error, I discovered that multiple similar lock inversion scenarios can occur. Hence, this series addresses potential deadlocks for two classes of locks, one in each patch:
1. Fix potential deadlocks for &fown_struct.lock
2. Fix potential deadlock for &fasync_struct.fa_lock
v1 -> v2:
- Added WARN_ON_ONCE(irqs_disabled()) before calls to read_lock_irq, with elaboration in the commit message, as suggested by Jeff Layton.
Best wishes,
Desmond
Desmond Cheong Zhi Xi (2):
fcntl: fix potential deadlocks for &fown_struct.lock
fcntl: fix potential deadlock for &fasync_struct.fa_lock
fs/fcntl.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
--
2.25.1
next reply other threads:[~2021-07-07 2:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 2:35 Desmond Cheong Zhi Xi [this message]
2021-07-07 2:35 ` [PATCH v2 1/2] fcntl: fix potential deadlocks for &fown_struct.lock Desmond Cheong Zhi Xi
2021-07-07 6:05 ` Greg KH
2021-07-07 6:54 ` Desmond Cheong Zhi Xi
2021-07-07 10:44 ` Jeff Layton
2021-07-07 10:51 ` Greg KH
2021-07-07 11:40 ` Jeff Layton
2021-07-07 13:51 ` J. Bruce Fields
2021-07-07 15:06 ` Greg KH
2021-07-07 15:19 ` J. Bruce Fields
2021-07-07 15:31 ` Greg KH
2021-07-07 15:34 ` J. Bruce Fields
2021-07-07 15:46 ` Greg KH
2021-07-07 16:18 ` Jeff Layton
2021-07-07 16:25 ` Matthew Wilcox
2021-07-07 17:52 ` Jeff Layton
2021-07-07 17:58 ` Eric Biggers
2021-07-07 2:35 ` [PATCH v2 2/2] fcntl: fix potential deadlock for &fasync_struct.fa_lock Desmond Cheong Zhi Xi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707023548.15872-1-desmondcheongzx@gmail.com \
--to=desmondcheongzx@gmail.com \
--cc=bfields@fieldses.org \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).