From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD1BC07E95 for ; Wed, 7 Jul 2021 19:30:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF9A861CBD for ; Wed, 7 Jul 2021 19:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232160AbhGGTdd (ORCPT ); Wed, 7 Jul 2021 15:33:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:33292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhGGTdc (ORCPT ); Wed, 7 Jul 2021 15:33:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08D8661C6D; Wed, 7 Jul 2021 19:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625686252; bh=3pODlJmfBdRZUct1Nd+7/oWJuLC7tASVT2444KEehJA=; h=From:To:Cc:Subject:Date:From; b=jW49LuE5IDef38qMg2fJPfUyoUapV9yA8K76i0BmqMaLxTujkLYshGo++CxDhuC1s TlOoxvFV+rXcX2AzlaAxUdPOPQCmMDyuQNiPPp9qG9rkULA/X7jk7QTPX7tA9N7waN Oh6uBao8oal91hfx+oEeMxPzQgL4bzaygVH/fVCkwc3iNGAU8w15Qo+EfOqWMCTEZP UKitmWIhbisTePb64ayH4DAkW7MI5vKDwjkbSZP9YmpgvoxhBsnjQPOlixzkPcdI4q 11kWrpEY72K4q3j35hCPxFwNKrp2t2TdmEZOfmMchAJul7mat+C1VCNI1FIWakaMDe X9TrtiXqvCzXA== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: drop dirty node pages when cp is in error status Date: Wed, 7 Jul 2021 12:30:43 -0700 Message-Id: <20210707193043.969238-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Otherwise, writeback is going to fall in a loop to flush dirty inode forever before getting SBI_CLOSING. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index dd611efa8aa4..0be9e2d7120e 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1549,13 +1549,10 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted, trace_f2fs_writepage(page, NODE); if (unlikely(f2fs_cp_error(sbi))) { - if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) { - ClearPageUptodate(page); - dec_page_count(sbi, F2FS_DIRTY_NODES); - unlock_page(page); - return 0; - } - goto redirty_out; + ClearPageUptodate(page); + dec_page_count(sbi, F2FS_DIRTY_NODES); + unlock_page(page); + return 0; } if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) -- 2.32.0.93.g670b81a890-goog