From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C16C07E9C for ; Thu, 8 Jul 2021 03:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F11C961C9C for ; Thu, 8 Jul 2021 03:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230388AbhGHDVN (ORCPT ); Wed, 7 Jul 2021 23:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbhGHDVM (ORCPT ); Wed, 7 Jul 2021 23:21:12 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BBC2C06175F for ; Wed, 7 Jul 2021 20:18:31 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id o8so5192553ilf.12 for ; Wed, 07 Jul 2021 20:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9T+utMZuunfx662ohPO94qoZtpTEcl7gy4ZtO3dCnRk=; b=RSFOn9Fyok6NqB6pVJQsWOINqg0fmGywAVRJbO8VT6wIV8nJTWJv0VjXUDq1d7xFCm oONM6pJJiLpqrTerV+tgbfuzZ2t6qXZittqvUUEOKcz/vYJ4E4MJxpdl0kBcwXXuhbI8 UbRIJvm+kscN6mkL/+AtibUwKbMfCyWqE9M84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9T+utMZuunfx662ohPO94qoZtpTEcl7gy4ZtO3dCnRk=; b=bW4Cp40v4aFLJ82gY6Zbr+Wkdw4FWYi9sTqWNaUdzsy1/LEzwUjTTN2Jr7QFP3uIES MYHI44w/zLte3QihGh/efOAg/RN4Y0cLL1g8BWeMFWE3EieBMyEd614yl9PByPfktYK+ PlVsibl+AJmH0M9nWxn+Kzk0lttlfZOVu2dZbO+jyGcI7nsFgmJkBTwckQEva56mvQ76 xqEZe2jsvfhlXYGpC9QMPzfmq5V7Tpc+AuXVJNkgEDUStRVv98iWXM2dJgig3U+dYelJ qTul/iSEFuzpRXr75sR2DMFHbrD7Lh1IjRCbmuFwboPNkKc6V5NtlSA/OlwDfL72C7zB Grag== X-Gm-Message-State: AOAM532HgbNBcr96jQLwLeTiIewNbc4zhvAfUAeimCxIXDsrShGw2Lkv WcIys8crnlz04XZIfg2ep0E6XEC6tXiRJA== X-Google-Smtp-Source: ABdhPJyejhApA3rWl1rQFA3BRKanF3qwZu4S5QEagZ+XdsLOO5j3FEbgQLk3H5iWq00V0EGztof2yg== X-Received: by 2002:a05:6e02:78c:: with SMTP id q12mr7884200ils.243.1625714310809; Wed, 07 Jul 2021 20:18:30 -0700 (PDT) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id g12sm450538ioc.25.2021.07.07.20.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 20:18:30 -0700 (PDT) From: Shuah Khan To: shuah@kernel.org, gregkh@linuxfoundation.org Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests: firmware: Fix ingonred return val of asprintf() warn Date: Wed, 7 Jul 2021 21:18:27 -0600 Message-Id: <20210708031827.51293-1-skhan@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following ingonred return val of asprintf() warn during build: cc -Wall -O2 fw_namespace.c -o ../tools/testing/selftests/firmware/fw_namespace fw_namespace.c: In function ‘main’: fw_namespace.c:132:2: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 132 | asprintf(&fw_path, "/lib/firmware/%s", fw_name); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Shuah Khan --- tools/testing/selftests/firmware/fw_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/firmware/fw_namespace.c b/tools/testing/selftests/firmware/fw_namespace.c index 0e393cb5f42d..4c6f0cd83c5b 100644 --- a/tools/testing/selftests/firmware/fw_namespace.c +++ b/tools/testing/selftests/firmware/fw_namespace.c @@ -129,7 +129,8 @@ int main(int argc, char **argv) die("mounting tmpfs to /lib/firmware failed\n"); sys_path = argv[1]; - asprintf(&fw_path, "/lib/firmware/%s", fw_name); + if (asprintf(&fw_path, "/lib/firmware/%s", fw_name) < 0) + die("error: failed to build full fw_path\n"); setup_fw(fw_path); -- 2.30.2