linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-07-08 21:37 Stephen Rothwell
  2021-07-09  7:42 ` Dan Carpenter
  0 siblings, 1 reply; 28+ messages in thread
From: Stephen Rothwell @ 2021-07-08 21:37 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Dan Carpenter, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi all,

In commit

  b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")

Fixes tag

  Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)

has these problem(s):

  - Subject has leading but no trailing quotes
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2021-07-08 21:37 linux-next: Fixes tag needs some work in the amdgpu tree Stephen Rothwell
@ 2021-07-09  7:42 ` Dan Carpenter
  2021-07-09 13:01   ` Alex Deucher
  0 siblings, 1 reply; 28+ messages in thread
From: Dan Carpenter @ 2021-07-09  7:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Alex Deucher, Linux Kernel Mailing List, Linux Next Mailing List

On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
> 
> Fixes tag
> 
>   Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Oops.  Sorry.  I've created a fixes.sh like you say.

#!/bin/bash

git log -1 --format='Fixes: %h ("%s")' $*

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2021-07-09  7:42 ` Dan Carpenter
@ 2021-07-09 13:01   ` Alex Deucher
  0 siblings, 0 replies; 28+ messages in thread
From: Alex Deucher @ 2021-07-09 13:01 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List

On Fri, Jul 9, 2021 at 3:43 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Jul 09, 2021 at 07:37:11AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   b612f5c36279 ("drm/amdgpu: unlock on error in amdgpu_ras_debugfs_table_read()")
> >
> > Fixes tag
> >
> >   Fixes: c65b0805e77919 (""drm/amdgpu: RAS EEPROM table is now in debugfs)
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing quotes
> >     Just use
> >       git log -1 --format='Fixes: %h ("%s")'
>
> Oops.  Sorry.  I've created a fixes.sh like you say.
>

Fixed up locally.

Alex

> #!/bin/bash
>
> git log -1 --format='Fixes: %h ("%s")' $*
>
> regards,
> dan carpenter

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-11-17 22:50 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-11-17 22:50 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Roman Li, Jasdeep Dhillon, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

In commit

  e2ec2136832f ("drm/amd/display: Fix OLED brightness control on eDP")

Fixes tag

  Fixes: 7fd13baeb7a3a4 ("drm/amd/display: add support for multiple backlights")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags toether at the end of the
commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-11-09 22:01 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-11-09 22:01 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Evan Quan, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  d6874a709faa ("drm/amdgpu: fix uvd crash on Polaris12 during driver unloading")

Fixes tag

  Fixes: cdccf1ffe1a3 ("drm/amdgpu: Fix crash on device remove/driver unload")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d82e2c249c8f ("drm/amdgpu: Fix crash on device remove/driver unload")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-10-28  0:14 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-10-28  0:14 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  8bc3824f0ee2 ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set")

Fixes tag

  Fixes: 41724ea273cdda ("drm/amd/display: Add DP 2.0 MST DM Support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

  39b3c728e5ca ("drm/amd/display: Add DP 2.0 MST DM Support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-09-14 21:17 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-09-14 21:17 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Nicholas Kazlauskas, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  8e4826da95bc ("drm/amd/display: Fix white screen page fault for gpuvm")

Fixes tag

  Fixes: 64b1d0e8d50 ("drm/amd/display: Add DCN3.1 HWSEQ")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2021-06-02 22:39 Stephen Rothwell
@ 2021-06-03 10:15 ` Michel Dänzer
  0 siblings, 0 replies; 28+ messages in thread
From: Michel Dänzer @ 2021-06-03 10:15 UTC (permalink / raw)
  To: Stephen Rothwell, Alex Deucher
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 2021-06-03 12:39 a.m., Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    56b019f8eda0 ("drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB")
> 
> Fixes tag
> 
>    Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Got it.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer


^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-06-02 22:39 Stephen Rothwell
  2021-06-03 10:15 ` Michel Dänzer
  0 siblings, 1 reply; 28+ messages in thread
From: Stephen Rothwell @ 2021-06-02 22:39 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Michel Dänzer, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  56b019f8eda0 ("drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB")

Fixes tag

  Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-05-11 22:19 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-05-11 22:19 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi all,

In commit

  d4378f172385 ("drm/amdgpu/display: fix warning when CONFIG_DRM_AMD_DC_DCN is not defined")

Fixes tag

  Fixes: 77a49c458931 ("drm/amd/display: Support for DMUB AUX")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 81927e2808be ("drm/amd/display: Support for DMUB AUX")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-05-11 22:17 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-05-11 22:17 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  337142ee10ca ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not defined")

Fixes tag

  Fixes: 77a49c458931 ("drm/amd/display: Support for DMUB AUX")

has these problem(s):

  - Target SHA1 does not exist

Maybe you ment

Fixes: 81927e2808be ("drm/amd/display: Support for DMUB AUX")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2021-05-10 23:08 ` David Ward
@ 2021-05-11 13:40   ` Alex Deucher
  0 siblings, 0 replies; 28+ messages in thread
From: Alex Deucher @ 2021-05-11 13:40 UTC (permalink / raw)
  To: David Ward
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List

I'll fix it up.

Alex

On Mon, May 10, 2021 at 7:08 PM David Ward <david.ward@gatech.edu> wrote:
>
> On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >    0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
> >
> > Fixes tag
> >
> >    Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> > has these problem(s):
> >
> >    - Subject does not match target commit subject
> >      Just use
> >       git log -1 --format='Fixes: %h ("%s")'
> >
> > Maybe you meant
> >
> > Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> My apologies. The correct hash is in fact 9037246bb2da. (Commit
> a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include
> the sysfs file.) It seems I inadvertently copied the wrong hash when
> preparing the commit message.
>
> Please let me know if I need to resubmit this patch.
>
> Thank you,
>
> David
>
>

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2021-05-10 22:42 Stephen Rothwell
@ 2021-05-10 23:08 ` David Ward
  2021-05-11 13:40   ` Alex Deucher
  0 siblings, 1 reply; 28+ messages in thread
From: David Ward @ 2021-05-10 23:08 UTC (permalink / raw)
  To: Stephen Rothwell, Alex Deucher
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
>
> Fixes tag
>
>    Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
>
> has these problem(s):
>
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
>
My apologies. The correct hash is in fact 9037246bb2da. (Commit 
a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include 
the sysfs file.) It seems I inadvertently copied the wrong hash when 
preparing the commit message.

Please let me know if I need to resubmit this patch.

Thank you,

David



^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-05-10 22:42 Stephen Rothwell
  2021-05-10 23:08 ` David Ward
  0 siblings, 1 reply; 28+ messages in thread
From: Stephen Rothwell @ 2021-05-10 22:42 UTC (permalink / raw)
  To: Alex Deucher
  Cc: David Ward, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

In commit

  0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")

Fixes tag

  Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-03-08  2:07 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-03-08  2:07 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Felix Kuehling, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  47c45c39d1a4 ("drm/amdkfd: Use a new capability bit for SRAM ECC")

Fixes tag

  Fixes: 7ec177bdcfc1 ("drm/amdkfd: fix set kfd node ras properties value")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant:

Fixes: 5436ab94cd94 ("drm/amdkfd: fix set kfd node ras properties value")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2021-01-26  8:58 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2021-01-26  8:58 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Bhawanpreet Lakha, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

Hi all,

In commit

  289970f0be61 ("drm/amd/display: Fix unused variable warning")

Fixes tag

  Fixes: e177af8a43da ("drm/amd/display: Fix deadlock during gpu reset v3")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2020-10-27 21:22 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2020-10-27 21:22 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  8f76b1bbe713 ("drm/amdgpu/pm: fix the fan speed in fan1_input in manual mode for navi1x")

Fixes tag

  Fixes: 3033e9f1c2de ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f6eb433954bf ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2020-09-22 21:33 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2020-09-22 21:33 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Lewis Huang, stable

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  bc6058294cb2 ("drm/amd/display: [FIX] update clock under two conditions")

Fixes tag

  Fixes: 06f9b1475d98 ("drm/amd/display: update clock when non-seamless boot stream exist")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 598c13b21e25 ("drm/amd/display: update clock when non-seamless boot stream exist")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2020-06-23 22:45 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2020-06-23 22:45 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chen Tao

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  82d6b9745744 ("drm/amdgpu/debugfs: fix memory leak when amdgpu_virt_enable_access_debugfs failed")

Fixes tag

  Fixes: 95a2f917387a2 ("drm/amdgpu: restrict debugfs register accessunder SR-IOV")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2020-05-27 23:29 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2020-05-27 23:29 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  31fba61da070 ("drm/amdgpu/pm: don't bail for in_suspend")

Fixes tag

  Fixes: f7c8d853b029df ("drm/amdgpu/pm: return an error during GPU reset or suspend")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2d0021bb7157 ("drm/amdgpu/pm: return an error during GPU reset or suspend")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* RE: linux-next: Fixes tag needs some work in the amdgpu tree
  2019-12-19  4:46   ` Alex Deucher
@ 2019-12-20  0:52     ` Chen, Guchun
  0 siblings, 0 replies; 28+ messages in thread
From: Chen, Guchun @ 2019-12-20  0:52 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

Thanks Alex and Stephen.
I will be aware of this next time. Sorry for the inconvenience again.

Regards,
Guchun

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com> 
Sent: Thursday, December 19, 2019 12:47 PM
To: Chen, Guchun <Guchun.Chen@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>; Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

On Wed, Dec 18, 2019 at 8:22 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Stephen,
>
> Sorry for the inconvenience. How I can fix this?
>

Already fixed.

Alex

> Regards,
> Guchun
>
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Thursday, December 19, 2019 5:26 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
> Subject: linux-next: Fixes tag needs some work in the amdgpu tree
>
> Hi all,
>
> In commit
>
>   caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")
>
> Fixes tag
>
>   Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")
>
> Also, please keep all the tags together at the end of the commit message.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2019-12-19  1:22 ` Chen, Guchun
@ 2019-12-19  4:46   ` Alex Deucher
  2019-12-20  0:52     ` Chen, Guchun
  0 siblings, 1 reply; 28+ messages in thread
From: Alex Deucher @ 2019-12-19  4:46 UTC (permalink / raw)
  To: Chen, Guchun
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Dec 18, 2019 at 8:22 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Stephen,
>
> Sorry for the inconvenience. How I can fix this?
>

Already fixed.

Alex

> Regards,
> Guchun
>
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Thursday, December 19, 2019 5:26 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
> Subject: linux-next: Fixes tag needs some work in the amdgpu tree
>
> Hi all,
>
> In commit
>
>   caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")
>
> Fixes tag
>
>   Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")
>
> Also, please keep all the tags together at the end of the commit message.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 28+ messages in thread

* RE: linux-next: Fixes tag needs some work in the amdgpu tree
  2019-12-18 21:25 Stephen Rothwell
@ 2019-12-19  1:22 ` Chen, Guchun
  2019-12-19  4:46   ` Alex Deucher
  0 siblings, 1 reply; 28+ messages in thread
From: Chen, Guchun @ 2019-12-19  1:22 UTC (permalink / raw)
  To: Stephen Rothwell, Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[AMD Official Use Only - Internal Distribution Only]

Hi Stephen,

Sorry for the inconvenience. How I can fix this?

Regards,
Guchun

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Thursday, December 19, 2019 5:26 AM
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Guchun <Guchun.Chen@amd.com>
Subject: linux-next: Fixes tag needs some work in the amdgpu tree

Hi all,

In commit

  caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")

Fixes tag

  Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")

Also, please keep all the tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2019-12-18 21:25 Stephen Rothwell
  2019-12-19  1:22 ` Chen, Guchun
  0 siblings, 1 reply; 28+ messages in thread
From: Stephen Rothwell @ 2019-12-18 21:25 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Guchun Chen

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

In commit

  caa01659028a ("drm/amdgpu: move umc offset to one new header file for Arcturus")

Fixes tag

  Fixes: 9686563c4c42 drm/amdgpu: Added RAS UMC error query support for Arcturus

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 4cf781c24c3b ("drm/amdgpu: Added RAS UMC error query support for Arcturus")

Also, please keep all the tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2019-11-26 19:44 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2019-11-26 19:44 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bhawanpreet Lakha

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hi all,

In commit

  1b8b896f1ea5 ("drm/amd/display: Null check aconnector in event_property_validate")

Fixes tag

  Fixes: cc5dae9f6286 ("drm/amd/display: Refactor HDCP to handle multiple

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b1abe5586ffc ("drm/amd/display: Refactor HDCP to handle multiple displays per link")

Also, please do not split Fixes tags over more than one line and keep
them with the rest of the tags at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: linux-next: Fixes tag needs some work in the amdgpu tree
  2019-10-02 22:11 Stephen Rothwell
@ 2019-10-04  6:26 ` S, Shirish
  0 siblings, 0 replies; 28+ messages in thread
From: S, Shirish @ 2019-10-04  6:26 UTC (permalink / raw)
  To: Stephen Rothwell, Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, S, Shirish

Hi Stephen,


On 10/3/2019 3:41 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")
>
> Fixes tag
>
>    Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")
>
> has these problem(s):
>
>    - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

Yes, I meant "aa978594cf7f".

Regards,

Shirish S

-- 
Regards,
Shirish S


^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2019-10-02 22:11 Stephen Rothwell
  2019-10-04  6:26 ` S, Shirish
  0 siblings, 1 reply; 28+ messages in thread
From: Stephen Rothwell @ 2019-10-02 22:11 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shirish S

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")

Fixes tag

  Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling policy")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* linux-next: Fixes tag needs some work in the amdgpu tree
@ 2019-03-18  4:54 Stephen Rothwell
  0 siblings, 0 replies; 28+ messages in thread
From: Stephen Rothwell @ 2019-03-18  4:54 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi Alex,

Commits

  b208c3a940b9 ("drm/amdkfd: avoid HMM change cause circular lock")
  8a3397a108e5 ("drm/amdgpu: use HMM callback to replace mmu notifier")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2021-11-17 22:50 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 21:37 linux-next: Fixes tag needs some work in the amdgpu tree Stephen Rothwell
2021-07-09  7:42 ` Dan Carpenter
2021-07-09 13:01   ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17 22:50 Stephen Rothwell
2021-11-09 22:01 Stephen Rothwell
2021-10-28  0:14 Stephen Rothwell
2021-09-14 21:17 Stephen Rothwell
2021-06-02 22:39 Stephen Rothwell
2021-06-03 10:15 ` Michel Dänzer
2021-05-11 22:19 Stephen Rothwell
2021-05-11 22:17 Stephen Rothwell
2021-05-10 22:42 Stephen Rothwell
2021-05-10 23:08 ` David Ward
2021-05-11 13:40   ` Alex Deucher
2021-03-08  2:07 Stephen Rothwell
2021-01-26  8:58 Stephen Rothwell
2020-10-27 21:22 Stephen Rothwell
2020-09-22 21:33 Stephen Rothwell
2020-06-23 22:45 Stephen Rothwell
2020-05-27 23:29 Stephen Rothwell
2019-12-18 21:25 Stephen Rothwell
2019-12-19  1:22 ` Chen, Guchun
2019-12-19  4:46   ` Alex Deucher
2019-12-20  0:52     ` Chen, Guchun
2019-11-26 19:44 Stephen Rothwell
2019-10-02 22:11 Stephen Rothwell
2019-10-04  6:26 ` S, Shirish
2019-03-18  4:54 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).