* [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status
@ 2021-07-09 15:29 Colin King
2021-07-12 9:13 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-09 15:29 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Connor McAdams, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable status is being initialized with a value that is never
read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/hda/patch_ca0132.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index b66e7bdbf483..50ca72ee586e 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2270,7 +2270,7 @@ static int dspio_send_scp_message(struct hda_codec *codec,
unsigned int *bytes_returned)
{
struct ca0132_spec *spec = codec->spec;
- int status = -1;
+ int status;
unsigned int scp_send_size = 0;
unsigned int total_size;
bool waiting_for_resp = false;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status
2021-07-09 15:29 [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status Colin King
@ 2021-07-12 9:13 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-07-12 9:13 UTC (permalink / raw)
To: Colin King
Cc: Jaroslav Kysela, Takashi Iwai, Connor McAdams, alsa-devel,
kernel-janitors, linux-kernel
On Fri, 09 Jul 2021 17:29:38 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable status is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-12 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 15:29 [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status Colin King
2021-07-12 9:13 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).