From: Jarkko Sakkinen <jarkko@kernel.org>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linux-integrity@vger.kernel.org,
"Ard Biesheuvel" <ardb@kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Loïc Yhuel" <loic.yhuel@gmail.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jerry Snitselaar" <jsnitsel@redhat.com>,
"Matthew Garrett" <mjg59@google.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi/tpm: Differentiate missing and invalid final event log table.
Date: Fri, 9 Jul 2021 19:38:46 +0300 [thread overview]
Message-ID: <20210709163846.3e753oectgbt7wh7@kernel.org> (raw)
In-Reply-To: <20210708094654.4157-1-msuchanek@suse.de>
On Thu, Jul 08, 2021 at 11:46:54AM +0200, Michal Suchanek wrote:
> Missing TPM final event log table is not a firmware bug.
>
> Clearly if providing event log in the old format makes the final event
> log invalid it should not be provided at least in that case.
>
> Fixes: b4f1874c6216 ("tpm: check event log version before reading final events")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> drivers/firmware/efi/tpm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
> index c1955d320fec..8f665678e9e3 100644
> --- a/drivers/firmware/efi/tpm.c
> +++ b/drivers/firmware/efi/tpm.c
> @@ -62,9 +62,11 @@ int __init efi_tpm_eventlog_init(void)
> tbl_size = sizeof(*log_tbl) + log_tbl->size;
> memblock_reserve(efi.tpm_log, tbl_size);
>
> - if (efi.tpm_final_log == EFI_INVALID_TABLE_ADDR ||
> - log_tbl->version != EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {
> - pr_warn(FW_BUG "TPM Final Events table missing or invalid\n");
> + if (efi.tpm_final_log == EFI_INVALID_TABLE_ADDR) {
> + pr_info("TPM Final Events table not present\n");
> + goto out;
> + } else if (log_tbl->version != EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {
> + pr_warn(FW_BUG "TPM Final Events table invalid\n");
> goto out;
> }
>
> --
> 2.26.2
>
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
next prev parent reply other threads:[~2021-07-09 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 9:46 [PATCH] efi/tpm: Differentiate missing and invalid final event log table Michal Suchanek
2021-07-09 16:38 ` Jarkko Sakkinen [this message]
2021-07-16 16:04 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709163846.3e753oectgbt7wh7@kernel.org \
--to=jarkko@kernel.org \
--cc=ardb@kernel.org \
--cc=javierm@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.yhuel@gmail.com \
--cc=mjg59@google.com \
--cc=msuchanek@suse.de \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).