* [PATCH] iio: accel: fxls8962af: Initialize return value
@ 2021-07-09 3:15 Souptick Joarder
2021-07-09 3:36 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2021-07-09 3:15 UTC (permalink / raw)
To: jic23, lars, sean, andriy.shevchenko, linus.walleij
Cc: linux-iio, linux-kernel, Souptick Joarder, kernel test robot,
Dan Carpenter
kernel test robot throws below warning ->
smatch warnings:
drivers/iio/accel/fxls8962af-core.c:640
fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
Initialize it.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/iio/accel/fxls8962af-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 078d87865fde..8af1c8f58e83 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -628,7 +628,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
u16 *buffer, int samples,
int sample_length)
{
- int i, ret;
+ int i, ret = -EINVAL;
for (i = 0; i < samples; i++) {
ret = regmap_raw_read(data->regmap, FXLS8962AF_BUF_X_LSB,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: accel: fxls8962af: Initialize return value
2021-07-09 3:15 [PATCH] iio: accel: fxls8962af: Initialize return value Souptick Joarder
@ 2021-07-09 3:36 ` Fabio Estevam
2021-07-09 6:48 ` Sean Nyekjaer
[not found] ` <CAFqt6zZ3WOv6sv5iVgkbYBhnxvv=t1pE8ZxEiC7=j5qugvy=NA@mail.gmail.com>
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-07-09 3:36 UTC (permalink / raw)
To: Souptick Joarder
Cc: Jonathan Cameron, Lars-Peter Clausen, Sean Nyekjaer,
Andy Shevchenko, Linus Walleij, linux-iio, linux-kernel,
kernel test robot, Dan Carpenter
Hi Souptick,
On Fri, Jul 9, 2021 at 12:17 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> kernel test robot throws below warning ->
>
> smatch warnings:
> drivers/iio/accel/fxls8962af-core.c:640
> fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
>
> Initialize it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..8af1c8f58e83 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -628,7 +628,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
> u16 *buffer, int samples,
> int sample_length)
> {
> - int i, ret;
> + int i, ret = -EINVAL;
>
> for (i = 0; i < samples; i++) {
> ret = regmap_raw_read(data->regmap, FXLS8962AF_BUF_X_LSB,
Would the change below work?
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct
fxls8962af_data *data,
return ret;
}
- return ret;
+ return 0;
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: accel: fxls8962af: Initialize return value
2021-07-09 3:36 ` Fabio Estevam
@ 2021-07-09 6:48 ` Sean Nyekjaer
2021-07-10 17:16 ` Fabio Estevam
[not found] ` <CAFqt6zZ3WOv6sv5iVgkbYBhnxvv=t1pE8ZxEiC7=j5qugvy=NA@mail.gmail.com>
1 sibling, 1 reply; 6+ messages in thread
From: Sean Nyekjaer @ 2021-07-09 6:48 UTC (permalink / raw)
To: Fabio Estevam
Cc: Souptick Joarder, Jonathan Cameron, Lars-Peter Clausen,
Andy Shevchenko, Linus Walleij, linux-iio, linux-kernel,
kernel test robot, Dan Carpenter
Hi Souptick and Fabio.
On Fri, Jul 09, 2021 at 12:36:25AM -0300, Fabio Estevam wrote:
> Hi Souptick,
>
> On Fri, Jul 9, 2021 at 12:17 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > kernel test robot throws below warning ->
> >
> > smatch warnings:
> > drivers/iio/accel/fxls8962af-core.c:640
> > fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
> >
> > Initialize it.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Missing fixes-tag ;)
[ ... ]
>
> Would the change below work?
>
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct
> fxls8962af_data *data,
> return ret;
> }
>
> - return ret;
> + return 0;
> }
I have already submitted a patch for this :)
https://patchwork.kernel.org/project/linux-iio/patch/20210623113115.581609-1-sean@geanix.com/
/Sean
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: accel: fxls8962af: Initialize return value
[not found] ` <CAFqt6zZ3WOv6sv5iVgkbYBhnxvv=t1pE8ZxEiC7=j5qugvy=NA@mail.gmail.com>
@ 2021-07-09 14:35 ` Sean Nyekjaer
2021-07-09 17:12 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Sean Nyekjaer @ 2021-07-09 14:35 UTC (permalink / raw)
To: Souptick Joarder
Cc: Fabio Estevam, Jonathan Cameron, Lars-Peter Clausen,
Andy Shevchenko, Linus Walleij, linux-iio, linux-kernel,
kernel test robot, Dan Carpenter
On Fri, Jul 09, 2021 at 07:50:48PM +0530, Souptick Joarder wrote:
> On Fri, 9 Jul, 2021, 9:06 am Fabio Estevam, <festevam@gmail.com> wrote:
>
> > Hi Souptick,
> >
> > On Fri, Jul 9, 2021 at 12:17 AM Souptick Joarder <jrdr.linux@gmail.com>
> > wrote:
> > >
> > > kernel test robot throws below warning ->
> > >
> > > smatch warnings:
> > > drivers/iio/accel/fxls8962af-core.c:640
> > > fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
> > >
> > > Initialize it.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > > ---
> > > drivers/iio/accel/fxls8962af-core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/accel/fxls8962af-core.c
> > b/drivers/iio/accel/fxls8962af-core.c
> > > index 078d87865fde..8af1c8f58e83 100644
> > > --- a/drivers/iio/accel/fxls8962af-core.c
> > > +++ b/drivers/iio/accel/fxls8962af-core.c
> > > @@ -628,7 +628,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct
> > fxls8962af_data *data,
> > > u16 *buffer, int samples,
> > > int sample_length)
> > > {
> > > - int i, ret;
> > > + int i, ret = -EINVAL;
> > >
> > > for (i = 0; i < samples; i++) {
> > > ret = regmap_raw_read(data->regmap, FXLS8962AF_BUF_X_LSB,
> >
> > Would the change below work?
> >
>
> This function returns -ERRNO when failed. If it is not entering loop,
> ideally it should return -ERRNO, not 0. No ?
samples can't be 0, as fxls8962af_fifo_transfer() is never called if
samples are 0 :)
>
> >
> > --- a/drivers/iio/accel/fxls8962af-core.c
> > +++ b/drivers/iio/accel/fxls8962af-core.c
> > @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct
> > fxls8962af_data *data,
> > return ret;
> > }
> >
> > - return ret;
> > + return 0;
> > }
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: accel: fxls8962af: Initialize return value
2021-07-09 14:35 ` Sean Nyekjaer
@ 2021-07-09 17:12 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-07-09 17:12 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: Souptick Joarder, Fabio Estevam, Jonathan Cameron,
Lars-Peter Clausen, Andy Shevchenko, Linus Walleij, linux-iio,
linux-kernel, kernel test robot
On Fri, Jul 09, 2021 at 04:35:05PM +0200, Sean Nyekjaer wrote:
> On Fri, Jul 09, 2021 at 07:50:48PM +0530, Souptick Joarder wrote:
> > On Fri, 9 Jul, 2021, 9:06 am Fabio Estevam, <festevam@gmail.com> wrote:
> >
> > > Hi Souptick,
> > >
> > > On Fri, Jul 9, 2021 at 12:17 AM Souptick Joarder <jrdr.linux@gmail.com>
> > > wrote:
> > > >
> > > > kernel test robot throws below warning ->
> > > >
> > > > smatch warnings:
> > > > drivers/iio/accel/fxls8962af-core.c:640
> > > > fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
> > > >
> > > > Initialize it.
> > > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > > > ---
> > > > drivers/iio/accel/fxls8962af-core.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/iio/accel/fxls8962af-core.c
> > > b/drivers/iio/accel/fxls8962af-core.c
> > > > index 078d87865fde..8af1c8f58e83 100644
> > > > --- a/drivers/iio/accel/fxls8962af-core.c
> > > > +++ b/drivers/iio/accel/fxls8962af-core.c
> > > > @@ -628,7 +628,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct
> > > fxls8962af_data *data,
> > > > u16 *buffer, int samples,
> > > > int sample_length)
> > > > {
> > > > - int i, ret;
> > > > + int i, ret = -EINVAL;
> > > >
> > > > for (i = 0; i < samples; i++) {
> > > > ret = regmap_raw_read(data->regmap, FXLS8962AF_BUF_X_LSB,
> > >
> > > Would the change below work?
> > >
> >
> > This function returns -ERRNO when failed. If it is not entering loop,
> > ideally it should return -ERRNO, not 0. No ?
>
> samples can't be 0, as fxls8962af_fifo_transfer() is never called if
> samples are 0 :)
>
Yeah, you're right. Smatch can figure that out if you build the cross
function DB, but it's a little bit trick for kbuild to use the DB when
it runs on so many git trees. The DB takes hours to build so kbuild
doesn't use it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: accel: fxls8962af: Initialize return value
2021-07-09 6:48 ` Sean Nyekjaer
@ 2021-07-10 17:16 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-07-10 17:16 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: Souptick Joarder, Jonathan Cameron, Lars-Peter Clausen,
Andy Shevchenko, Linus Walleij, linux-iio, linux-kernel,
kernel test robot, Dan Carpenter
Hi Sean,
On Fri, Jul 9, 2021 at 3:48 AM Sean Nyekjaer <sean@geanix.com> wrote:
> I have already submitted a patch for this :)
> https://patchwork.kernel.org/project/linux-iio/patch/20210623113115.581609-1-sean@geanix.com/
Please resubmit your patch with a commit log.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-10 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 3:15 [PATCH] iio: accel: fxls8962af: Initialize return value Souptick Joarder
2021-07-09 3:36 ` Fabio Estevam
2021-07-09 6:48 ` Sean Nyekjaer
2021-07-10 17:16 ` Fabio Estevam
[not found] ` <CAFqt6zZ3WOv6sv5iVgkbYBhnxvv=t1pE8ZxEiC7=j5qugvy=NA@mail.gmail.com>
2021-07-09 14:35 ` Sean Nyekjaer
2021-07-09 17:12 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).