From: trix@redhat.com
To: mdf@kernel.org, corbet@lwn.net, hao.wu@intel.com,
michal.simek@xilinx.com
Cc: linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Tom Rix <trix@redhat.com>
Subject: [RFC PATCH v10 0/3] standard release after compat_id change
Date: Fri, 9 Jul 2021 11:45:07 -0700 [thread overview]
Message-ID: <20210709184511.2521508-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
My objection to 'fpga: Use standard class dev_release function' here
https://lore.kernel.org/linux-fpga/20210709004206.244607-1-russell.h.weight@intel.com/
Is that it has 2 register functions for mgr and region.
This is caused by compat_id data being stored at the wrong level.
By first moving the compat_id data to the implementation level.
'fpga: remove compat_id from fpga_manager and fpga_region'
https://lore.kernel.org/linux-fpga/20210709134229.2510349-6-trix@redhat.com/
2 registers are not needed.
This change removes the register_full()'s as well as the info structs.
Tested on dfl/n3000
Russ Weight (3):
fpga: mgr: Use standard dev_release for class driver
fpga: bridge: Use standard dev_release for class driver
fpga: region: Use standard dev_release for class driver
Documentation/driver-api/fpga/fpga-bridge.rst | 12 +-
Documentation/driver-api/fpga/fpga-mgr.rst | 23 ++-
Documentation/driver-api/fpga/fpga-region.rst | 4 -
drivers/fpga/altera-cvp.c | 12 +-
drivers/fpga/altera-fpga2sdram.c | 12 +-
drivers/fpga/altera-freeze-bridge.c | 10 +-
drivers/fpga/altera-hps2fpga.c | 12 +-
drivers/fpga/altera-pr-ip-core.c | 7 +-
drivers/fpga/altera-ps-spi.c | 9 +-
drivers/fpga/dfl-fme-br.c | 10 +-
drivers/fpga/dfl-fme-mgr.c | 10 +-
drivers/fpga/dfl-fme-region.c | 7 +-
drivers/fpga/dfl.c | 12 +-
drivers/fpga/fpga-bridge.c | 122 +++----------
drivers/fpga/fpga-mgr.c | 166 +++++-------------
drivers/fpga/fpga-region.c | 108 +++---------
drivers/fpga/ice40-spi.c | 9 +-
drivers/fpga/machxo2-spi.c | 9 +-
drivers/fpga/of-fpga-region.c | 10 +-
drivers/fpga/socfpga-a10.c | 16 +-
drivers/fpga/socfpga.c | 9 +-
drivers/fpga/stratix10-soc.c | 16 +-
drivers/fpga/ts73xx-fpga.c | 9 +-
drivers/fpga/xilinx-pr-decoupler.c | 17 +-
drivers/fpga/xilinx-spi.c | 11 +-
drivers/fpga/zynq-fpga.c | 16 +-
drivers/fpga/zynqmp-fpga.c | 9 +-
include/linux/fpga/fpga-bridge.h | 30 +++-
include/linux/fpga/fpga-mgr.h | 16 +-
include/linux/fpga/fpga-region.h | 12 +-
30 files changed, 226 insertions(+), 499 deletions(-)
--
2.26.3
next reply other threads:[~2021-07-09 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 18:45 trix [this message]
2021-07-09 18:45 ` [RFC PATCH v10 1/3] fpga: mgr: Use standard dev_release for class driver trix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709184511.2521508-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=corbet@lwn.net \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).