From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE782C11F69 for ; Sat, 10 Jul 2021 02:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE5BD613C9 for ; Sat, 10 Jul 2021 02:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234690AbhGJCf6 (ORCPT ); Fri, 9 Jul 2021 22:35:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:48606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232135AbhGJCba (ORCPT ); Fri, 9 Jul 2021 22:31:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90A73613EB; Sat, 10 Jul 2021 02:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625884063; bh=gAzHfHwMcrbK0IuXaFlkK9UgQAbquYqjzfgSqsleyfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fWm2yQ0rSRd+Xoa3xQNFZ0+WtBhLc/8nLvpJ++gbYUczA0Gi6DveGpkTTtvOHMlhq zInsoMus/IUtH6VaMUwB2GXB96YcMxF5iC7IF6swuQxa+YsbHCWVuAFkKebM79lYKZ lINj5/w2sohKuHxkdHBvIAKoDXAS1rktMqjDFAMTagep5pgvofnjpeya9pJmOTsb3G J4N+XkEYTV7ngRkK9oLenF5w+arOjlX5Ac7IXbukgUy6EqD7MT0wwrOYVHEDRhfqmG IpkeATQ8npunGtztajZ9Mh+xlcZmJMXrHLm/gvOeYIX81pSZNlM+MjpbTOZog4qfHb IguktaZ8AXDjQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Christie , Manish Rangankar , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 26/63] scsi: qedi: Fix null ref during abort handling Date: Fri, 9 Jul 2021 22:26:32 -0400 Message-Id: <20210710022709.3170675-26-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022709.3170675-1-sashal@kernel.org> References: <20210710022709.3170675-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Christie [ Upstream commit 5777b7f0f03ce49372203b6521631f62f2810c8f ] If qedi_process_cmd_cleanup_resp finds the cmd it frees the work and sets list_tmf_work to NULL, so qedi_tmf_work should check if list_tmf_work is non-NULL when it wants to force cleanup. Link: https://lore.kernel.org/r/20210525181821.7617-20-michael.christie@oracle.com Reviewed-by: Manish Rangankar Signed-off-by: Mike Christie Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qedi/qedi_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index 90aa64604ad7..37b8f08d5020 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -1451,7 +1451,7 @@ static void qedi_tmf_work(struct work_struct *work) ldel_exit: spin_lock_bh(&qedi_conn->tmf_work_lock); - if (!qedi_cmd->list_tmf_work) { + if (qedi_cmd->list_tmf_work) { list_del_init(&list_work->list); qedi_cmd->list_tmf_work = NULL; kfree(list_work); -- 2.30.2