From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C83AC07E99 for ; Sat, 10 Jul 2021 02:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CE67613C8 for ; Sat, 10 Jul 2021 02:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232913AbhGJCpG (ORCPT ); Fri, 9 Jul 2021 22:45:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:34526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235236AbhGJCns (ORCPT ); Fri, 9 Jul 2021 22:43:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71EC061411; Sat, 10 Jul 2021 02:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625884780; bh=ge8k98Jmmh4+fuZZPKhrjZr04XydmynMYogBFTwWaOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TAnw21+RdpfRwGuxs2aSVkYLesfXzcdPjtQbkKoz2zwO6DaubI4hlw9F8+54ZwZnc Mig/Gcq/MQGMZeqWsz5xBOlb6ODHIQN24yczMK794c4iWAG5gFf3v1C3GZOqdRI6Ge xRWnjth1/2Hl+rIIbrKMH0+JkgaNHOBPvEf/1Og2gIsYitNp8onOVeXr8pGkijTWh3 7u09HbyxThsSfQ7YfG7eUYHttuqkGnmCE7iYr/DWbTAh1xbcdT/QZfbRyY1VtSZyFM KFbtCYAZasJedyJg40/gDE366g53D86Xc6iVqYbD7m6kplcfJ34QozscoIVQINbY5J 8p4SuIqDiOOdQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Hulk Robot , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 18/23] usb: gadget: hid: fix error return code in hid_bind() Date: Fri, 9 Jul 2021 22:39:07 -0400 Message-Id: <20210710023912.3172972-18-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710023912.3172972-1-sashal@kernel.org> References: <20210710023912.3172972-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 88693f770bb09c196b1eb5f06a484a254ecb9924 ] Fix to return a negative error code from the error handling case instead of 0. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210618043835.2641360-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/legacy/hid.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/hid.c b/drivers/usb/gadget/legacy/hid.c index 7e5d2c48476e..97329ba5d382 100644 --- a/drivers/usb/gadget/legacy/hid.c +++ b/drivers/usb/gadget/legacy/hid.c @@ -175,8 +175,10 @@ static int hid_bind(struct usb_composite_dev *cdev) struct usb_descriptor_header *usb_desc; usb_desc = usb_otg_descriptor_alloc(gadget); - if (!usb_desc) + if (!usb_desc) { + status = -ENOMEM; goto put; + } usb_otg_descriptor_init(gadget, usb_desc); otg_desc[0] = usb_desc; otg_desc[1] = NULL; -- 2.30.2