linux-next: Fixes tag needs some work in the printk tree

linux-next: Fixes tag needs some work in the printk tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

In commit

  11e4b63abbe2 ("printk/console: Check consistent sequence number when handling race in console_unlock()")

Fixes tag

  Fixes: commit 996e966640ddea7b535c ("printk: remove logbuf_lock")

has these problem(s):

  - leading word 'commit' unexpected

Not worth rebasing to fix, but please remember for the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the printk tree

[Petr Mladek]

On Tue 2020-11-03 08:32:01, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8a8424bf2439 ("init/Kconfig: Fix CPU number in LOG_CPU_MAX_BUF_SHIFT description")
> 
> Fixes tag
> 
>   Fixes: 23b2899f7f ("printk: allow increasing the ring buffer depending on the number of CPUs")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Should be fixed now. It is a pity that checkpatch.pl did not warn
about it.

Thanks for the report.

Best Regards,
Petr

linux-next: Fixes tag needs some work in the printk tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

In commit

  8a8424bf2439 ("init/Kconfig: Fix CPU number in LOG_CPU_MAX_BUF_SHIFT description")

Fixes tag

  Fixes: 23b2899f7f ("printk: allow increasing the ring buffer depending on the number of CPUs")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the printk tree

[Sergey Senozhatsky]

On (20/07/28 08:19), Stephen Rothwell wrote:
> On Mon, 27 Jul 2020 17:13:44 +0206 John Ogness <john.ogness@linutronix.de> wrote:
> >
> > On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
[..]
> > > Maybe you meant
> > >
> > > Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")  
> >
> > Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
> > logs.

Neither did I. The tag made sense to me, because it fixes a regression
after all.

> Well, it makes sense to use them if they are stable (i.e. the tree they
> are in does not rebase) which, by this part of the cycle, I would
> *hope* would be true (but sometimes isn't :-().

So we probably should not have Fixes tags in linux-next commits
(printk rework branch) then, for the time being. I'll keep an eye
on that.

	-ss

Re: linux-next: Fixes tag needs some work in the printk tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Hi John,

On Mon, 27 Jul 2020 17:13:44 +0206 John Ogness <john.ogness@linutronix.de> wrote:
>
> On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > In commit
> >
> >   96b917f8e9ec ("printk: ringbuffer: support dataless records")
> >
> > Fixes tag
> >
> >   Fixes: ("printk: use the lockless ringbuffer")
> >
> > has these problem(s):
> >
> >   - No SHA1 recognised
> >
> > Maybe you meant
> >
> > Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")  
> 
> Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
> logs.

Well, it makes sense to use them if they are stable (i.e. the tree they
are in does not rebase) which, by this part of the cycle, I would
*hope* would be true (but sometimes isn't :-().

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the printk tree

[John Ogness]

On 2020-07-27, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> In commit
>
>   96b917f8e9ec ("printk: ringbuffer: support dataless records")
>
> Fixes tag
>
>   Fixes: ("printk: use the lockless ringbuffer")
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> Maybe you meant
>
> Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")

Yes, sorry. I did not think linux-next SHA1 hashes were used in commit
logs.

John Ogness

linux-next: Fixes tag needs some work in the printk tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

In commit

  96b917f8e9ec ("printk: ringbuffer: support dataless records")

Fixes tag

  Fixes: ("printk: use the lockless ringbuffer")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 896fbe20b4e2 ("printk: use the lockless ringbuffer")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the printk tree

[Petr Mladek]

On Thu 2019-04-25 23:30:49, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   e43bb4d0feb8 ("vsprintf: Consistent %pK handling for kptr_restrict == 0")
> 
> Fixes tag
> 
>   Fixes: commit ef0010a30935de4e0211 ("vsprintf: don't use 'restricted_pointer()' when not restricting")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Thanks for the report! I have just fixed it.

Best Regards,
Petr

linux-next: Fixes tag needs some work in the printk tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi all,

In commit

  e43bb4d0feb8 ("vsprintf: Consistent %pK handling for kptr_restrict == 0")

Fixes tag

  Fixes: commit ef0010a30935de4e0211 ("vsprintf: don't use 'restricted_pointer()' when not restricting")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]