From: Alan Stern <stern@rowland.harvard.edu>
To: syzbot <syzbot+72af3105289dcb4c055b@syzkaller.appspotmail.com>
Cc: gregkh@linuxfoundation.org, johan@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
mathias.nyman@linux.intel.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in do_proc_control/usb_submit_urb
Date: Sun, 11 Jul 2021 11:53:45 -0400 [thread overview]
Message-ID: <20210711155345.GB293743@rowland.harvard.edu> (raw)
In-Reply-To: <20210710145003.GA271154@rowland.harvard.edu>
On Sat, Jul 10, 2021 at 10:50:03AM -0400, Alan Stern wrote:
> On Sat, Jul 10, 2021 at 04:11:15AM -0700, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: ee268dee Add linux-next specific files for 20210707
> > git tree: linux-next
>
> Is this an old version of syzbot? I thought it had been fixed up to
> give a real URL (one that "#syz test:" would accept) for the git
> tree and a 12-digit SHA-1 abbreviation for the HEAD commit.
Actually, on further thought it looks like only a one-line change is
needed. Let's make sure it works.
Alan Stern
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ee268dee
> Index: usb-devel/drivers/usb/core/devio.c
> ===================================================================
> --- usb-devel.orig/drivers/usb/core/devio.c
> +++ usb-devel/drivers/usb/core/devio.c
> @@ -1133,7 +1133,7 @@ static int do_proc_control(struct usb_de
> "wIndex=%04x wLength=%04x\n",
> ctrl->bRequestType, ctrl->bRequest, ctrl->wValue,
> ctrl->wIndex, ctrl->wLength);
> - if (ctrl->bRequestType & 0x80) {
> + if ((ctrl->bRequestType & USB_DIR_IN) && ctrl->wLength) {
> pipe = usb_rcvctrlpipe(dev, 0);
> snoop_urb(dev, NULL, pipe, ctrl->wLength, tmo, SUBMIT, NULL, 0);
>
next prev parent reply other threads:[~2021-07-11 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 11:11 [syzbot] WARNING in do_proc_control/usb_submit_urb syzbot
2021-07-10 14:50 ` Alan Stern
2021-07-10 22:58 ` syzbot
2021-07-11 0:36 ` Alan Stern
2021-07-11 15:53 ` Alan Stern [this message]
2021-07-11 16:07 ` syzbot
2021-07-12 14:00 ` Alan Stern
2021-07-12 15:29 ` Johan Hovold
2021-07-12 15:50 ` Johan Hovold
2021-07-12 16:14 ` Alan Stern
2021-07-12 16:24 ` Dmitry Vyukov
2021-07-12 18:48 ` Alan Stern
2021-07-15 7:19 ` Dmitry Vyukov
2021-07-12 16:32 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210711155345.GB293743@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=syzbot+72af3105289dcb4c055b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).