From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F42C11F90 for ; Mon, 12 Jul 2021 07:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 200F561580 for ; Mon, 12 Jul 2021 07:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352416AbhGLHyp (ORCPT ); Mon, 12 Jul 2021 03:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343882AbhGLHUI (ORCPT ); Mon, 12 Jul 2021 03:20:08 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C10C025397; Mon, 12 Jul 2021 00:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4Ku+fho4Qa2ctqbzzklG68fzz9r2UqJK370+yapiLZc=; b=ag7kV+FXM4JBQH7e2//dT1ivFv A59SAxXTXopPlbcEbf+RoxCFo0UquO5n03eZLpE4Gh+7KE/cDJfcUy5RtV3h/E1+WhRnqKkogLEBO C61h1r1gvS0HVVVxIX3kSR8Be0J7H0+bx+WlSiyuKEq9WFAMZOHYYBKBFILR0vs5T8TI=; Received: from p200300ccff0a76001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0a:7600:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1m2q6E-0005aH-RK; Mon, 12 Jul 2021 09:11:30 +0200 Date: Mon, 12 Jul 2021 09:11:30 +0200 From: Andreas Kemnade To: Jonathan Cameron , lars@metafoo.de, sre@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property Message-ID: <20210712091130.2096cf23@aktux> In-Reply-To: <20210711112039.43c4af7b@jic23-huawei> References: <20210705113637.28908-1-andreas@kemnade.info> <20210705113637.28908-3-andreas@kemnade.info> <20210711112039.43c4af7b@jic23-huawei> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Jul 2021 11:20:39 +0100 Jonathan Cameron wrote: > On Mon, 5 Jul 2021 13:36:37 +0200 > Andreas Kemnade wrote: > > > Read voltage_now via IIO and provide the property. > > > > Signed-off-by: Andreas Kemnade > > Reported-by: kernel test robot > Huh? Seems unlikely it pointed out that this patch was necessary in general. > If highlighting a particular fix in an earlier version, then state what it was > in the commit message. Note for fixes that get rolled into patches, it's > often just mentioned in the change log and we skip the tag because it can > cause confusion. > The robot found a problem in v1 (missing depends on IIO). It is fixed now. The message from the bot tells to add a tag. It seems not to make sense. But probably the bot is also running on public branches (which will not be rebase) and uses the same message where it actually makes sense. I will send a v3 with that tag removed and the other comment addressed. Regards, Andreas