From: Will Deacon <will@kernel.org>
To: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Sam Tebbs <sam.tebbs@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH] kasan: fix build for CONFIG_KASAN_HW_TAGS
Date: Mon, 12 Jul 2021 10:58:32 +0100 [thread overview]
Message-ID: <20210712095832.GA27643@willie-the-truck> (raw)
In-Reply-To: <CA+fCnZdHADek_3bFcLdkk7=XiRL25F0n6VaGGOrw-uUpDLxYYw@mail.gmail.com>
On Sat, Jul 10, 2021 at 09:16:14PM +0200, Andrey Konovalov wrote:
> On Thu, Jul 8, 2021 at 4:44 PM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > When CONFIG_KASAN_HW_TAGS is selected, <linux/kasan.h> uses _RET_IP_,
> > but doesn't explicitly include <linux/kernel.h> where this is defined.
> >
> > We used to get this via a transitive include, but since commit:
> >
> > f39650de687e3576 ("kernel.h: split out panic and oops helpers")
> >
> > ... this is no longer the case, and so we get a build failure:
> >
> > | CC arch/arm64/mm/kasan_init.o
> > | In file included from arch/arm64/mm/kasan_init.c:10:
> > | ./include/linux/kasan.h: In function 'kasan_slab_free':
> > | ./include/linux/kasan.h:211:39: error: '_RET_IP_' undeclared (first use in this function)
> > | 211 | return __kasan_slab_free(s, object, _RET_IP_, init);
> > | | ^~~~~~~~
> > | ./include/linux/kasan.h:211:39: note: each undeclared identifier is reported only once for each function it appears in
> > | ./include/linux/kasan.h: In function 'kasan_kfree_large':
> > | ./include/linux/kasan.h:219:28: error: '_RET_IP_' undeclared (first use in this function)
> > | 219 | __kasan_kfree_large(ptr, _RET_IP_);
> > | | ^~~~~~~~
> > | ./include/linux/kasan.h: In function 'kasan_slab_free_mempool':
> > | ./include/linux/kasan.h:226:34: error: '_RET_IP_' undeclared (first use in this function)
> > | 226 | __kasan_slab_free_mempool(ptr, _RET_IP_);
> > | | ^~~~~~~~
> > | ./include/linux/kasan.h: In function 'kasan_check_byte':
> > | ./include/linux/kasan.h:277:35: error: '_RET_IP_' undeclared (first use in this function)
> > | 277 | return __kasan_check_byte(addr, _RET_IP_);
> > | | ^~~~~~~~
> >
> > Fix this by including <linux/kernel.h> explicitly.
>
> Hi Mark,
>
> Marco already sent a fix for this. It should be in the mm tree.
> (Although the link to it in the Andrew's notification email doesn't
> work. But they rarely do :)
Do you have a link to the patch? I couldn't spot it in linux-next.
Thanks,
Will
next prev parent reply other threads:[~2021-07-12 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 14:44 [PATCH] kasan: fix build for CONFIG_KASAN_HW_TAGS Mark Rutland
2021-07-10 19:16 ` Andrey Konovalov
2021-07-12 8:37 ` Mark Rutland
2021-07-12 9:58 ` Will Deacon [this message]
2021-07-12 10:03 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712095832.GA27643@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=ryabinin.a.a@gmail.com \
--cc=sam.tebbs@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).