From: SeongJae Park <sj38.park@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Brendan Higgins <brendanhiggins@google.com>,
SeongJae Park <sj38.park@gmail.com>,
dlatypov@google.com, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH v2] kunit: tool: Assert the version requirement
Date: Mon, 12 Jul 2021 19:47:18 +0000 [thread overview]
Message-ID: <20210712194718.20813-1-sjpark@amazon.de> (raw)
In-Reply-To: <6fb4706b-ce58-a397-d777-10338c2a8d4e@linuxfoundation.org>
From: SeongJae Park <sjpark@amazon.de>
On Mon, 12 Jul 2021 13:42:34 -0600 Shuah Khan <skhan@linuxfoundation.org> wrote:
> On 6/28/21 1:41 PM, Brendan Higgins wrote:
> > On Thu, Jun 17, 2021 at 12:46 AM SeongJae Park <sj38.park@gmail.com> wrote:
> >>
> >> Commit 87c9c1631788 ("kunit: tool: add support for QEMU") on the 'next'
> >> tree adds 'from __future__ import annotations' in 'kunit_kernel.py'.
> >> Because it is supported on only >=3.7 Python, people using older Python
> >> will get below error:
> >>
> >> Traceback (most recent call last):
> >> File "./tools/testing/kunit/kunit.py", line 20, in <module>
> >> import kunit_kernel
> >> File "/home/sjpark/linux/tools/testing/kunit/kunit_kernel.py", line 9
> >> from __future__ import annotations
> >> ^
> >> SyntaxError: future feature annotations is not defined
> >>
> >> This commit adds a version assertion in 'kunit.py', so that people get
> >> more explicit error message like below:
> >>
> >> Traceback (most recent call last):
> >> File "./tools/testing/kunit/kunit.py", line 15, in <module>
> >> assert sys.version_info >= (3, 7), "Python version is too old"
> >> AssertionError: Python version is too old
> >>
> >> Signed-off-by: SeongJae Park <sjpark@amazon.de>
>
> Your from and Signed-off-by email addresses don't match.
>
> Please resend the patch with the correction.
Sorry, my fault. Will send fixed one as a reply to this.
Thanks,
SeongJae Park
>
> thanks,
> -- Shuah
next prev parent reply other threads:[~2021-07-12 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:40 [PATCH] kunit: tool: Assert version requirement SeongJae Park
2021-06-16 21:14 ` Daniel Latypov
2021-06-17 7:39 ` SeongJae Park
2021-06-17 7:46 ` [PATCH v2] kunit: tool: Assert the " SeongJae Park
2021-06-22 23:28 ` Daniel Latypov
2021-06-22 23:55 ` Daniel Latypov
2021-06-28 13:37 ` SeongJae Park
2021-06-28 19:51 ` Brendan Higgins
2021-06-28 19:41 ` Brendan Higgins
2021-07-12 19:42 ` Shuah Khan
2021-07-12 19:47 ` SeongJae Park [this message]
2021-07-12 19:52 ` [PATCH v3] " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712194718.20813-1-sjpark@amazon.de \
--to=sj38.park@gmail.com \
--cc=brendanhiggins@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).