From: Daniel Thompson <daniel.thompson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Sumit Garg <sumit.garg@linaro.org>,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] kdb: Get rid of custom debug heap allocator
Date: Tue, 13 Jul 2021 16:10:32 +0100 [thread overview]
Message-ID: <20210713151032.hvsbufswijxt6uxk@maple.lan> (raw)
In-Reply-To: <CAD=FV=X9w_eY9cSkJLsF57bqL=FQFNcybG+P6tYT5mWTnG3TJA@mail.gmail.com>
On Tue, Jul 13, 2021 at 06:45:52AM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 13, 2021 at 4:24 AM Sumit Garg <sumit.garg@linaro.org> wrote:
> >
> > > > int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
> > > > {
> > > > int ret = 0;
> > > > unsigned long symbolsize = 0;
> > > > unsigned long offset = 0;
> > > > -#define knt1_size 128 /* must be >= kallsyms table size */
> > > > - char *knt1 = NULL;
> > > > + static char namebuf[KSYM_NAME_LEN];
> > >
> > > I guess this also ends up fixing a bug too, right? My greps show that
> > > "KSYM_NAME_LEN" is 512
> >
> > I can see "KSYM_NAME_LEN" defined as 128 here [1]. Are you looking at
> > any other header file?
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kallsyms.h#n18
>
> Ah ha, it's recent! See commit f2f6175186f4 ("kallsyms: increase
> maximum kernel symbol length to 512")
Ineed. So recent that I think it hasn't been merged to mainline yet!
This patch is part of the rust patch set. IIUC it is in linux-next for
wider testing but I'd be surprised if it gets merged to mainline anytime
soon (and even more amazed if it is merged without being rebased and
given a new hash value ;-) ).
Daniel.
next prev parent reply other threads:[~2021-07-13 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 12:24 [PATCH v3] kdb: Get rid of custom debug heap allocator Sumit Garg
2021-07-12 22:49 ` Doug Anderson
2021-07-13 11:24 ` Sumit Garg
2021-07-13 13:45 ` Doug Anderson
2021-07-13 15:10 ` Daniel Thompson [this message]
2021-07-13 15:12 ` Doug Anderson
2021-07-14 5:03 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713151032.hvsbufswijxt6uxk@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).