Re: [PATCH] venus: vdec: decoded picture buffer handling during reconfig sequence

From: kernel test robot <lkp@intel.com>
To: Mansur Alisha Shaik <mansur@codeaurora.org>,
	linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org,
	dikshita@codeaurora.org,
	Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: Re: [PATCH] venus: vdec: decoded picture buffer handling during reconfig sequence
Date: Wed, 14 Jul 2021 08:31:29 +0800	[thread overview]
Message-ID: <202107140801.QKnMeWDq-lkp@intel.com> (raw)
In-Reply-To: <1626181116-2650-1-git-send-email-mansur@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

Hi Mansur,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.14-rc1 next-20210713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mansur-Alisha-Shaik/venus-vdec-decoded-picture-buffer-handling-during-reconfig-sequence/20210713-205958
base:   git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/971381185ff2025c3cda25145ba6dcd1702fdaeb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mansur-Alisha-Shaik/venus-vdec-decoded-picture-buffer-handling-during-reconfig-sequence/20210713-205958
        git checkout 971381185ff2025c3cda25145ba6dcd1702fdaeb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/qcom/venus/helpers.c:128:5: warning: no previous prototype for 'venus_helper_get_free_dpb_tag' [-Wmissing-prototypes]
     128 | int venus_helper_get_free_dpb_tag(struct venus_inst *inst)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/venus_helper_get_free_dpb_tag +128 drivers/media/platform/qcom/venus/helpers.c

   127	
 > 128	int venus_helper_get_free_dpb_tag(struct venus_inst *inst)
   129	{
   130		u32 i;
   131	
   132		for (i = 0; i < VB2_MAX_FRAME; i++) {
   133			if (inst->dpb_out_tag[i] == 0) {
   134				inst->dpb_out_tag[i] = i + VB2_MAX_FRAME;
   135				return inst->dpb_out_tag[i];
   136			}
   137		}
   138	
   139		return 0;
   140	}
   141	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60287 bytes --]