From: Bill Wendling <morbo@google.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Ariel Elior <aelior@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
GR-everest-linux-l2@marvell.com,
"David S . Miller" <davem@davemloft.net>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bill Wendling <morbo@google.com>
Subject: [PATCH 1/3] base: remove unused variable 'no_warn'
Date: Wed, 14 Jul 2021 02:17:45 -0700 [thread overview]
Message-ID: <20210714091747.2814370-2-morbo@google.com> (raw)
In-Reply-To: <20210714091747.2814370-1-morbo@google.com>
Fix the following build warning:
drivers/base/module.c:36:6: error: variable 'no_warn' set but not used [-Werror,-Wunused-but-set-variable]
int no_warn;
Signed-off-by: Bill Wendling <morbo@google.com>
---
drivers/base/module.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/base/module.c b/drivers/base/module.c
index 46ad4d636731..81d84a066a38 100644
--- a/drivers/base/module.c
+++ b/drivers/base/module.c
@@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk)
void module_add_driver(struct module *mod, struct device_driver *drv)
{
char *driver_name;
- int no_warn;
struct module_kobject *mk = NULL;
if (!drv)
@@ -59,12 +58,11 @@ void module_add_driver(struct module *mod, struct device_driver *drv)
return;
/* Don't check return codes; these calls are idempotent */
- no_warn = sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
+ sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
driver_name = make_driver_name(drv);
if (driver_name) {
module_create_drivers_dir(mk);
- no_warn = sysfs_create_link(mk->drivers_dir, &drv->p->kobj,
- driver_name);
+ sysfs_create_link(mk->drivers_dir, &drv->p->kobj, driver_name);
kfree(driver_name);
}
}
--
2.32.0.93.g670b81a890-goog
next prev parent reply other threads:[~2021-07-14 9:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 9:17 [PATCH 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-14 9:17 ` Bill Wendling [this message]
2021-07-14 12:15 ` [PATCH 1/3] base: remove unused variable 'no_warn' kernel test robot
2021-07-14 9:17 ` [PATCH 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-14 9:17 ` [PATCH 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:19 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-26 20:19 ` [PATCH v2 1/3] base: mark 'no_warn' as unused Bill Wendling
2021-07-26 20:47 ` Nathan Chancellor
2021-07-26 21:01 ` Bill Wendling
2021-07-27 5:27 ` Greg Kroah-Hartman
2021-07-27 6:15 ` Bill Wendling
2021-07-27 6:41 ` Greg Kroah-Hartman
2021-07-27 7:08 ` Bill Wendling
2021-07-27 7:12 ` Greg Kroah-Hartman
2021-07-27 7:15 ` Bill Wendling
2021-07-27 17:39 ` Nick Desaulniers
2021-07-27 17:42 ` Nick Desaulniers
2021-07-27 17:59 ` Greg Kroah-Hartman
2021-07-27 18:31 ` Nick Desaulniers
2021-07-27 18:44 ` Greg Kroah-Hartman
2021-07-27 19:02 ` Nick Desaulniers
2021-07-27 19:23 ` Bill Wendling
2021-07-27 20:13 ` Segher Boessenkool
2021-07-27 20:22 ` Bill Wendling
2021-07-27 20:24 ` Bill Wendling
2021-07-27 18:32 ` Nathan Chancellor
2021-07-27 19:04 ` Nick Desaulniers
2021-07-27 19:10 ` Nathan Chancellor
2021-07-27 19:12 ` Bill Wendling
2021-07-26 20:19 ` [PATCH v2 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-26 20:36 ` Nathan Chancellor
2021-07-26 20:19 ` [PATCH v2 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:40 ` Nathan Chancellor
2021-07-27 3:14 ` Martin K. Petersen
2021-07-29 3:38 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714091747.2814370-2-morbo@google.com \
--to=morbo@google.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).