From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com,
Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8723bs: fix camel case issue
Date: Wed, 14 Jul 2021 18:26:05 +0300 [thread overview]
Message-ID: <20210714152605.GK1931@kadam> (raw)
In-Reply-To: <a708b2b9902bedf5bd0466b05516a4c5b4f43723.1626275102.git.fabioaiuto83@gmail.com>
On Wed, Jul 14, 2021 at 05:11:14PM +0200, Fabio Aiuto wrote:
> fix following post commit hook checkpatch issue:
>
> CHECK: Avoid CamelCase: <NetType>
> 45: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:170:
> +#define is_supported_ht(NetType) (((NetType)
> & (WIRELESS_11_24N)) ? true : false)
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/ieee80211.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
> index 8eb0557a077a..b2c1a7dafcee 100644
> --- a/drivers/staging/rtl8723bs/include/ieee80211.h
> +++ b/drivers/staging/rtl8723bs/include/ieee80211.h
> @@ -167,7 +167,7 @@ enum network_type {
>
> #define IsSupportedTxCCK(NetType) (((NetType) & (WIRELESS_11B)) ? true : false)
> #define IsSupportedTxOFDM(NetType) (((NetType) & (WIRELESS_11G) ? true : false)
These are the same.
> -#define is_supported_ht(NetType) (((NetType) & (WIRELESS_11_24N)) ? true : false)
> +#define is_supported_ht(net_type) (((net_type) & (WIRELESS_11_24N)) ? true : false)
>
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-14 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 15:11 [PATCH 0/3] staging: rtl8723bs: add get_channel implementation Fabio Aiuto
2021-07-14 15:11 ` [PATCH 1/3] staging: rtl8723bs: add get_channel cfg80211 implementation Fabio Aiuto
2021-07-14 15:11 ` [PATCH 2/3] staging: rtl8723bs: convert IsSupportedHT to snake_case Fabio Aiuto
2021-07-14 15:11 ` [PATCH 3/3] staging: rtl8723bs: fix camel case issue Fabio Aiuto
2021-07-14 15:26 ` Dan Carpenter [this message]
2021-07-14 19:04 ` Fabio Aiuto
2021-07-17 8:29 ` Dan Carpenter
2021-07-17 9:01 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714152605.GK1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).