From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH 06/13] mailbox: pcc: Add pcc_mbox_chan structure to hold shared memory region info
Date: Wed, 14 Jul 2021 19:18:43 +0100 [thread overview]
Message-ID: <20210714181843.GC49078@e120937-lin> (raw)
In-Reply-To: <20210708180851.2311192-7-sudeep.holla@arm.com>
On Thu, Jul 08, 2021 at 07:08:44PM +0100, Sudeep Holla wrote:
> Currently PCC mailbox controller sets con_priv in each channel to hold
> the pointer to pcct subspace entry it corresponds to. The mailbox uses
nit: s/uses/users
> will then fetch this pointer from the channel descriptor they get when
> they request for the channel. Using that pointer they then parse the
> pcct entry again to fetch all the information about shared memory region.
>
> In order to remove individual users of PCC mailbox parsing the PCCT
> subspace entries to fetch same information, let us consolidate the same
> in pcc mailbox controller by parsing all the shared memory region
> information into a structure that can also hold the mbox_chan pointer it
> represent.
>
> This can then be used as main PCC mailbox channel pointer that we can
> return as part of pcc_mbox_request_channel instead of standard mailbox
> channel pointer.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/mailbox/pcc.c | 27 +++++++++++++++++++++++++++
> include/acpi/pcc.h | 9 +++++++++
> 2 files changed, 36 insertions(+)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 5f19bee71c04..affde0995d52 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -67,11 +67,13 @@ static struct mbox_chan *pcc_mbox_channels;
> /**
> * struct pcc_chan_info - PCC channel specific information
> *
> + * @chan: PCC channel information with Shared Memory Region info
> * @db_vaddr: cached virtual address for doorbell register
> * @db_ack_vaddr: cached virtual address for doorbell ack register
> * @db_irq: doorbell interrupt
> */
> struct pcc_chan_info {
> + struct pcc_mbox_chan chan;
> void __iomem *db_vaddr;
> void __iomem *db_ack_vaddr;
> int db_irq;
> @@ -469,6 +471,27 @@ static void pcc_parse_subspace_db_reg(struct pcc_chan_info *pchan,
> db_reg->bit_width / 8);
> }
>
> +/**
> + * pcc_parse_subspace_shmem - Parse the PCC Shared Memory Region information
> + *
> + * @pchan: Pointer to the PCC channel info structure.
> + * @pcct_entry: Pointer to the ACPI subtable header.
> + *
> + */
> +static void pcc_parse_subspace_shmem(struct pcc_chan_info *pchan,
> + struct acpi_subtable_header *pcct_entry)
> +{
> + struct acpi_pcct_subspace *pcct_ss;
> +
> + pcct_ss = (struct acpi_pcct_subspace *)pcct_entry;
> +
> + pchan->chan.shmem_base_addr = pcct_ss->base_address;
> + pchan->chan.shmem_size = pcct_ss->length;
> + pchan->chan.latency = pcct_ss->latency;
> + pchan->chan.max_access_rate = pcct_ss->max_access_rate;
> + pchan->chan.min_turnaround_time = pcct_ss->min_turnaround_time;
> +}
> +
Out of curiosity this ACPI provided latency/max_access/turnaround_time
are supposed to be considered and/or enforced where ? by the clients
using this controller ?
> /**
> * acpi_pcc_probe - Parse the ACPI tree for the PCCT.
> *
> @@ -536,6 +559,8 @@ static int __init acpi_pcc_probe(void)
> struct pcc_chan_info *pchan = chan_info + i;
> pcc_mbox_channels[i].con_priv = pcct_entry;
>
> + pchan->chan.mchan = &pcc_mbox_channels[i];
> +
> if (pcc_mbox_ctrl.txdone_irq) {
> rc = pcc_parse_subspace_irq(pchan, pcct_entry);
> if (rc < 0)
> @@ -543,6 +568,8 @@ static int __init acpi_pcc_probe(void)
> }
> pcc_parse_subspace_db_reg(pchan, pcct_entry);
>
> + pcc_parse_subspace_shmem(pchan, pcct_entry);
> +
> pcct_entry = (struct acpi_subtable_header *)
> ((unsigned long) pcct_entry + pcct_entry->length);
> }
> diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
> index 4dec4ed138cd..5e510a6b8052 100644
> --- a/include/acpi/pcc.h
> +++ b/include/acpi/pcc.h
> @@ -9,6 +9,15 @@
> #include <linux/mailbox_controller.h>
> #include <linux/mailbox_client.h>
>
> +struct pcc_mbox_chan {
> + struct mbox_chan *mchan;
> + u64 shmem_base_addr;
> + u64 shmem_size;
> + u32 latency;
> + u32 max_access_rate;
> + u16 min_turnaround_time;
> +};
> +
> #define MAX_PCC_SUBSPACES 256
> #ifdef CONFIG_PCC
> extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> --
> 2.25.1
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2021-07-14 18:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:08 [PATCH 00/13] mailbox: pcc: Add support for PCCT extended PCC subspaces Sudeep Holla
2021-07-08 18:08 ` [PATCH 01/13] mailbox: pcc: Fix doxygen comments Sudeep Holla
2021-07-08 18:51 ` Joe Perches
2021-07-08 21:03 ` Sudeep Holla
2021-07-08 18:08 ` [PATCH 02/13] ACPI: CPPC: " Sudeep Holla
2021-07-14 12:20 ` Rafael J. Wysocki
2021-07-14 15:12 ` Sudeep Holla
2021-07-14 16:07 ` Cristian Marussi
2021-07-14 16:14 ` Sudeep Holla
2021-07-08 18:08 ` [PATCH 03/13] mailbox: pcc: Refactor all PCC channel information into a structure Sudeep Holla
2021-07-14 16:54 ` Cristian Marussi
2021-07-15 11:27 ` Sudeep Holla
2021-07-15 12:50 ` Cristian Marussi
2021-07-15 13:24 ` Sudeep Holla
2021-07-08 18:08 ` [PATCH 04/13] mailbox: pcc: Consolidate subspace interrupt information parsing Sudeep Holla
2021-07-14 17:44 ` Cristian Marussi
2021-07-08 18:08 ` [PATCH 05/13] mailbox: pcc: Consolidate subspace doorbell register parsing Sudeep Holla
2021-07-14 18:09 ` Cristian Marussi
2021-07-08 18:08 ` [PATCH 06/13] mailbox: pcc: Add pcc_mbox_chan structure to hold shared memory region info Sudeep Holla
2021-07-14 18:18 ` Cristian Marussi [this message]
2021-07-15 11:22 ` Sudeep Holla
2021-07-08 18:08 ` [PATCH 07/13] mailbox: pcc: Use PCC mailbox channel pointer instead of standard Sudeep Holla
2021-07-08 18:08 ` [PATCH 08/13] mailbox: pcc: Rename doorbell ack to platform interrupt ack register Sudeep Holla
2021-07-08 18:08 ` [PATCH 09/13] mailbox: pcc: Add PCC register bundle and associated accessor functions Sudeep Holla
2021-07-08 18:08 ` [PATCH 10/13] mailbox: pcc: Avoid accessing PCCT table in pcc_send_data and pcc_mbox_irq Sudeep Holla
2021-07-14 18:37 ` Cristian Marussi
2021-07-15 13:38 ` Cristian Marussi
2021-07-08 18:08 ` [PATCH 11/13] mailbox: pcc: Drop handling invalid bit-width in {read,write}_register Sudeep Holla
2021-07-08 18:08 ` [PATCH 12/13] mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4) Sudeep Holla
2021-07-14 18:52 ` Cristian Marussi
2021-07-15 11:31 ` Sudeep Holla
2021-07-08 18:08 ` [PATCH 13/13] mailbox: pcc: Move bulk of PCCT parsing into pcc_mbox_probe Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714181843.GC49078@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).