linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] iio: adis: set GPIO reset pin direction
       [not found] <60e5ac8c.1c69fb81.c69f0.abab@mx.google.com>
@ 2021-07-08  9:54 ` Antti Keränen
  2021-07-08 10:05   ` Sa, Nuno
                     ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Antti Keränen @ 2021-07-08  9:54 UTC (permalink / raw)
  To: linux-iio
  Cc: Antti Keränen, Hannu Hartikainen, Lars-Peter Clausen,
	Michael Hennerich, Nuno Sa, Jonathan Cameron, open list

Set reset pin direction to output as the reset pin needs to be an active
low output pin.

Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
Signed-off-by: Antti Keränen <detegr@rbx.email>
---
Removed unnecessary toggling of the pin as requested by Lars-Peter. I
missed out on the conversation, but I agree this is better.

 drivers/iio/imu/adis.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
index 319b64b2fd88..f8b7837d8b8f 100644
--- a/drivers/iio/imu/adis.c
+++ b/drivers/iio/imu/adis.c
@@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
 	int ret;
 
 	/* check if the device has rst pin low */
-	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_ASIS);
+	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_OUT_HIGH);
 	if (IS_ERR(gpio))
 		return PTR_ERR(gpio);
 
 	if (gpio) {
-		gpiod_set_value_cansleep(gpio, 1);
 		msleep(10);
 		/* bring device out of reset */
 		gpiod_set_value_cansleep(gpio, 0);
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* RE: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-08  9:54 ` [PATCH v2] iio: adis: set GPIO reset pin direction Antti Keränen
@ 2021-07-08 10:05   ` Sa, Nuno
  2021-07-10 17:35   ` Jonathan Cameron
  2021-07-13 17:53   ` Jonathan Cameron
  2 siblings, 0 replies; 8+ messages in thread
From: Sa, Nuno @ 2021-07-08 10:05 UTC (permalink / raw)
  To: Antti Keränen, linux-iio
  Cc: Hannu Hartikainen, Lars-Peter Clausen, Hennerich, Michael,
	Jonathan Cameron, open list



> -----Original Message-----
> From: Antti Keränen <detegr@rbx.email>
> Sent: Thursday, July 8, 2021 11:54 AM
> To: linux-iio@vger.kernel.org
> Cc: Antti Keränen <detegr@rbx.email>; Hannu Hartikainen
> <hannu@hrtk.in>; Lars-Peter Clausen <lars@metafoo.de>; Hennerich,
> Michael <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> open list <linux-kernel@vger.kernel.org>
> Subject: [PATCH v2] iio: adis: set GPIO reset pin direction
> 
> Set reset pin direction to output as the reset pin needs to be an active
> low output pin.
> 
> Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Antti Keränen <detegr@rbx.email>
> ---
> Removed unnecessary toggling of the pin as requested by Lars-Peter. I
> missed out on the conversation, but I agree this is better.
> 
>  drivers/iio/imu/adis.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 319b64b2fd88..f8b7837d8b8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
>  	int ret;
> 
>  	/* check if the device has rst pin low */
> -	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_ASIS);
> +	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_OUT_HIGH);
>  	if (IS_ERR(gpio))
>  		return PTR_ERR(gpio);
> 
>  	if (gpio) {
> -		gpiod_set_value_cansleep(gpio, 1);
>  		msleep(10);
>  		/* bring device out of reset */
>  		gpiod_set_value_cansleep(gpio, 0);
> --

Reviewed-by: Nuno Sá <nuno.sa@analog.com> 


Thanks!

- Nuno Sá

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-08  9:54 ` [PATCH v2] iio: adis: set GPIO reset pin direction Antti Keränen
  2021-07-08 10:05   ` Sa, Nuno
@ 2021-07-10 17:35   ` Jonathan Cameron
  2021-07-13 17:53   ` Jonathan Cameron
  2 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2021-07-10 17:35 UTC (permalink / raw)
  To: Antti Keränen
  Cc: linux-iio, Hannu Hartikainen, Lars-Peter Clausen,
	Michael Hennerich, Nuno Sa, open list

On Thu,  8 Jul 2021 12:54:29 +0300
Antti Keränen <detegr@rbx.email> wrote:

> Set reset pin direction to output as the reset pin needs to be an active
> low output pin.
> 
> Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Antti Keränen <detegr@rbx.email>

Hi Antti,

For future reference (in IIO anyway as not all maintainers agree on this!)
please don't send a v2 in reply to v1.  It gets lots if anyone is using
a threaded email client as it's buried deep.  If I'd not been following
the discussion I'd probably have missed this.

Seems correct to me, but will leave on list a few more days as rc1 isn't
out yet so I don't have a good based to start collecting fixes on a the
moment.

Jonathan

> ---
> Removed unnecessary toggling of the pin as requested by Lars-Peter. I
> missed out on the conversation, but I agree this is better.
> 
>  drivers/iio/imu/adis.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 319b64b2fd88..f8b7837d8b8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
>  	int ret;
>  
>  	/* check if the device has rst pin low */
> -	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_ASIS);
> +	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_OUT_HIGH);
>  	if (IS_ERR(gpio))
>  		return PTR_ERR(gpio);
>  
>  	if (gpio) {
> -		gpiod_set_value_cansleep(gpio, 1);
>  		msleep(10);
>  		/* bring device out of reset */
>  		gpiod_set_value_cansleep(gpio, 0);


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-08  9:54 ` [PATCH v2] iio: adis: set GPIO reset pin direction Antti Keränen
  2021-07-08 10:05   ` Sa, Nuno
  2021-07-10 17:35   ` Jonathan Cameron
@ 2021-07-13 17:53   ` Jonathan Cameron
  2021-07-14 10:04     ` Antti Keränen
  2 siblings, 1 reply; 8+ messages in thread
From: Jonathan Cameron @ 2021-07-13 17:53 UTC (permalink / raw)
  To: Antti Keränen
  Cc: linux-iio, Hannu Hartikainen, Lars-Peter Clausen,
	Michael Hennerich, Nuno Sa, open list

On Thu,  8 Jul 2021 12:54:29 +0300
Antti Keränen <detegr@rbx.email> wrote:

> Set reset pin direction to output as the reset pin needs to be an active
> low output pin.
> 
> Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Antti Keränen <detegr@rbx.email>

So this sits on the boundary of whether it is a fix or not.
Do we want this to go into rc1 + stable?

If so a fixes tag would be great.

Thanks,

Jonathan

> ---
> Removed unnecessary toggling of the pin as requested by Lars-Peter. I
> missed out on the conversation, but I agree this is better.
> 
>  drivers/iio/imu/adis.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 319b64b2fd88..f8b7837d8b8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
>  	int ret;
>  
>  	/* check if the device has rst pin low */
> -	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_ASIS);
> +	gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_OUT_HIGH);
>  	if (IS_ERR(gpio))
>  		return PTR_ERR(gpio);
>  
>  	if (gpio) {
> -		gpiod_set_value_cansleep(gpio, 1);
>  		msleep(10);
>  		/* bring device out of reset */
>  		gpiod_set_value_cansleep(gpio, 0);


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-13 17:53   ` Jonathan Cameron
@ 2021-07-14 10:04     ` Antti Keränen
  2021-07-14 12:40       ` Jonathan Cameron
  0 siblings, 1 reply; 8+ messages in thread
From: Antti Keränen @ 2021-07-14 10:04 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Hannu Hartikainen, Lars-Peter Clausen,
	Michael Hennerich, Nuno Sa, open list

On Tue, Jul 13, 2021 at 06:53:11PM +0100, Jonathan Cameron wrote:
> So this sits on the boundary of whether it is a fix or not.
> Do we want this to go into rc1 + stable?

I'm not familiar enough with kernel development to give any opinions of
where this should go, but I would say this is a fix as the current code
won't work with certain hardware configurations.

> If so a fixes tag would be great.

This would mean a v3 patch with fixes tag included into the commit
message, right?

-- 
Antti

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-14 10:04     ` Antti Keränen
@ 2021-07-14 12:40       ` Jonathan Cameron
  2021-07-14 18:25         ` Antti Keränen
  0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Cameron @ 2021-07-14 12:40 UTC (permalink / raw)
  To: Antti Keränen
  Cc: Jonathan Cameron, linux-iio, Hannu Hartikainen,
	Lars-Peter Clausen, Michael Hennerich, Nuno Sa, open list

On Wed, 14 Jul 2021 13:04:45 +0300
Antti Keränen <detegr@rbx.email> wrote:

> On Tue, Jul 13, 2021 at 06:53:11PM +0100, Jonathan Cameron wrote:
> > So this sits on the boundary of whether it is a fix or not.
> > Do we want this to go into rc1 + stable?  
> 
> I'm not familiar enough with kernel development to give any opinions of
> where this should go, but I would say this is a fix as the current code
> won't work with certain hardware configurations.
> 
> > If so a fixes tag would be great.  
> 
> This would mean a v3 patch with fixes tag included into the commit
> message, right?
> 

Send the fixes tag in reply to this and I'll make sure it's added.
No need to bother with a v3 for just that.

Thanks,

Jonathan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-14 12:40       ` Jonathan Cameron
@ 2021-07-14 18:25         ` Antti Keränen
  2021-07-17 17:41           ` Jonathan Cameron
  0 siblings, 1 reply; 8+ messages in thread
From: Antti Keränen @ 2021-07-14 18:25 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Jonathan Cameron, linux-iio, Hannu Hartikainen,
	Lars-Peter Clausen, Michael Hennerich, Nuno Sa, open list

On Wed, Jul 14, 2021 at 01:40:05PM +0100, Jonathan Cameron wrote:
> Send the fixes tag in reply to this and I'll make sure it's added.
> No need to bother with a v3 for just that.

Fixes: ecb010d44108 ("iio: imu: adis: Refactor adis_initial_startup")

-- 
Antti

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] iio: adis: set GPIO reset pin direction
  2021-07-14 18:25         ` Antti Keränen
@ 2021-07-17 17:41           ` Jonathan Cameron
  0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2021-07-17 17:41 UTC (permalink / raw)
  To: Antti Keränen
  Cc: Jonathan Cameron, linux-iio, Hannu Hartikainen,
	Lars-Peter Clausen, Michael Hennerich, Nuno Sa, open list

On Wed, 14 Jul 2021 21:25:07 +0300
Antti Keränen <detegr@rbx.email> wrote:

> On Wed, Jul 14, 2021 at 01:40:05PM +0100, Jonathan Cameron wrote:
> > Send the fixes tag in reply to this and I'll make sure it's added.
> > No need to bother with a v3 for just that.  
> 
> Fixes: ecb010d44108 ("iio: imu: adis: Refactor adis_initial_startup")
Great.

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-17 17:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <60e5ac8c.1c69fb81.c69f0.abab@mx.google.com>
2021-07-08  9:54 ` [PATCH v2] iio: adis: set GPIO reset pin direction Antti Keränen
2021-07-08 10:05   ` Sa, Nuno
2021-07-10 17:35   ` Jonathan Cameron
2021-07-13 17:53   ` Jonathan Cameron
2021-07-14 10:04     ` Antti Keränen
2021-07-14 12:40       ` Jonathan Cameron
2021-07-14 18:25         ` Antti Keränen
2021-07-17 17:41           ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).