From: Jia He <justin.he@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
nd@arm.com, Jia He <justin.he@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: [PATCH RFC 12/13] mm: simplify the printing with '%pd' specifier
Date: Thu, 15 Jul 2021 11:15:32 +0800 [thread overview]
Message-ID: <20210715031533.9553-13-justin.he@arm.com> (raw)
In-Reply-To: <20210715031533.9553-1-justin.he@arm.com>
Use '%pd' to simplify the printing since kbasename(file_path()) is to
get the last dentry of the full path.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jia He <justin.he@arm.com>
---
mm/memory.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 747a01d495f2..350692ada6f7 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5217,18 +5217,14 @@ void print_vma_addr(char *prefix, unsigned long ip)
vma = find_vma(mm, ip);
if (vma && vma->vm_file) {
struct file *f = vma->vm_file;
- char *buf = (char *)__get_free_page(GFP_NOWAIT);
- if (buf) {
- char *p;
-
- p = file_path(f, buf, PAGE_SIZE);
- if (IS_ERR(p))
- p = "?";
- printk("%s%s[%lx+%lx]", prefix, kbasename(p),
+
+ if (f)
+ printk("%s%pd[%lx+%lx]", prefix, f->f_path.dentry,
vma->vm_start,
vma->vm_end - vma->vm_start);
- free_page((unsigned long)buf);
- }
+ else
+ printk("%s?[%lx+%lx]", prefix, vma->vm_start,
+ vma->vm_end - vma->vm_start);
}
mmap_read_unlock(mm);
}
--
2.17.1
next prev parent reply other threads:[~2021-07-15 3:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 3:15 [PATCH RFC 00/13] Simplify the print format string with new '%pD' Jia He
2021-07-15 3:15 ` [PATCH RFC 01/13] s390/hmcdrv: remove the redundant directory path in format string Jia He
2021-07-15 3:15 ` [PATCH RFC 02/13] afs: Remove the number postfix of '%pD' " Jia He
2021-07-15 3:15 ` [PATCH RFC 03/13] fs: " Jia He
2021-07-15 3:15 ` [PATCH RFC 04/13] NFS: " Jia He
2021-07-15 3:15 ` [PATCH RFC 05/13] NFSD: " Jia He
2021-07-15 3:15 ` [PATCH RFC 06/13] ovl: remove " Jia He
2021-07-15 3:15 ` [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with '%pD' specifier Jia He
2021-07-15 17:11 ` Darrick J. Wong
2021-07-16 6:11 ` Christoph Hellwig
2021-07-16 6:17 ` Justin He
2021-07-15 3:15 ` [PATCH RFC 08/13] fs/coredump: simplify the printing with '%pD' and '%pd' specifier Jia He
2021-07-15 3:15 ` [PATCH RFC 09/13] mm/filemap: simplify the printing with '%pD' specifier Jia He
2021-07-15 3:15 ` [PATCH RFC 10/13] usb: gadget: " Jia He
2021-07-15 7:26 ` Felipe Balbi
2021-07-15 8:10 ` Greg Kroah-Hartman
2021-07-15 3:15 ` [PATCH RFC 11/13] md/bitmap: " Jia He
2021-07-16 9:38 ` Guoqing Jiang
2021-07-23 17:05 ` Song Liu
2021-07-15 3:15 ` Jia He [this message]
2021-07-15 3:15 ` [PATCH RFC 13/13] ext4: " Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715031533.9553-13-justin.he@arm.com \
--to=justin.he@arm.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nd@arm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).