From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BB0C636C9 for ; Thu, 15 Jul 2021 21:09:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6318961396 for ; Thu, 15 Jul 2021 21:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbhGOVMi (ORCPT ); Thu, 15 Jul 2021 17:12:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhGOVMe (ORCPT ); Thu, 15 Jul 2021 17:12:34 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E37561396; Thu, 15 Jul 2021 21:09:40 +0000 (UTC) Date: Thu, 15 Jul 2021 17:09:33 -0400 From: Steven Rostedt To: Tom Zanussi Cc: LKML , Ingo Molnar , Andrew Morton , Namhyung Kim , Masami Hiramatsu , Tzvetomir Stoyanov Subject: Re: [PATCH] tracing: Do no reference char * as a string in histograms Message-ID: <20210715170933.109b5809@oasis.local.home> In-Reply-To: References: <20210715000206.025df9d2@rorschach.local.home> <17b88fc429ddd354cff468849bc16de25086df2d.camel@kernel.org> <20210715155400.28f0dfd0@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jul 2021 15:39:33 -0500 Tom Zanussi wrote: > Very nice! Really looking forward to playing around with this. We should be posting an RFC in a week or two. Just working on some other things at the moment. > > Yeah, if it's needed to enable the eprobes and since it also fixes a > crashing bug, I'm all for it. > > But should it also have an additional 'Fixes:' line?: > > Fixes: 5967bd5c4239 ("tracing: Let filter_assign_type() detect > FILTER_PTR_STRING") Added it. > > Acked-by: Tom Zanussi Thanks! -- Steve