* [PATCH] extcon: usb-gpio: Use the right includes
@ 2021-07-15 19:06 ` Linus Walleij
2021-07-15 21:36 ` Andy Shevchenko
2021-07-23 5:47 ` Chanwoo Choi
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2021-07-15 19:06 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi; +Cc: linux-kernel, linux-gpio, Linus Walleij
The USB GPIO extcon driver does not use any of the legacy
includes <linux/gpio.h> or <linux/of_gpio.h> but
exploits the fact that this brings in <linux/mod_device_table.h>.
Fix this up by using the right includes.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/extcon/extcon-usb-gpio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index f06be6d4e2a9..0cb440bdd5cb 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -7,18 +7,17 @@
*/
#include <linux/extcon-provider.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/mod_devicetable.h>
#define USB_GPIO_DEBOUNCE_MS 20 /* ms */
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: usb-gpio: Use the right includes
2021-07-15 19:06 ` [PATCH] extcon: usb-gpio: Use the right includes Linus Walleij
@ 2021-07-15 21:36 ` Andy Shevchenko
2021-07-23 5:47 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-07-15 21:36 UTC (permalink / raw)
To: Linus Walleij
Cc: MyungJoo Ham, Chanwoo Choi, Linux Kernel Mailing List,
open list:GPIO SUBSYSTEM
On Thu, Jul 15, 2021 at 10:35 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.
I like it!
Only one comment below, after addressing,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/mod_devicetable.h>
Can it be squeezed more or less in an ordered manner?
(before module.h I suppose)
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: usb-gpio: Use the right includes
2021-07-15 19:06 ` [PATCH] extcon: usb-gpio: Use the right includes Linus Walleij
2021-07-15 21:36 ` Andy Shevchenko
@ 2021-07-23 5:47 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2021-07-23 5:47 UTC (permalink / raw)
To: Linus Walleij, MyungJoo Ham; +Cc: linux-kernel, linux-gpio
On 7/16/21 4:06 AM, Linus Walleij wrote:
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/mod_devicetable.h>
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-23 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210715195441epcas1p2902263d7e7aeec6213a7ba554eff2695@epcas1p2.samsung.com>
2021-07-15 19:06 ` [PATCH] extcon: usb-gpio: Use the right includes Linus Walleij
2021-07-15 21:36 ` Andy Shevchenko
2021-07-23 5:47 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).