linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Zhang Qiao <zhangqiao22@huawei.com>
Cc: juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, peterz@infradead.org, pjt@google.com,
	vincent.guittot@linaro.org, daniel.m.jordan@oracle.com
Subject: Re: [PATCH -next v2] sched: Dec cfs_bandwith_used in destroy_cfs_bandwidth()
Date: Thu, 15 Jul 2021 16:28:53 -0400	[thread overview]
Message-ID: <20210715202853.no4f7zylvwc5etfu@oracle.com> (raw)
In-Reply-To: <20210715112433.32419-1-zhangqiao22@huawei.com>

Only nits left from my side anyway.  Looks fine otherwise!

There are a couple typos in the subject and changelog, cfs_bandwith_used
and cfs_bandwith_uesd.

On Thu, Jul 15, 2021 at 07:24:33PM +0800, Zhang Qiao wrote:
> +
> +void cfs_bandwidth_usage_inc(void)
> +{
> +	static_key_slow_inc(&__cfs_bandwidth_used);
> +}

Nothing calls this, and getting rid of it would potentially avoid a
janitorial patch later.

> +void cfs_bandwidth_usage_dec(void)

   static void cfs_bandwidth_usage_dec(void)

>  void cfs_bandwidth_usage_inc(void) {}
>  void cfs_bandwidth_usage_dec(void) {}

   static void cfs_bandwidth_usage_dec(void) {}

> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>  extern void cfs_bandwidth_usage_inc(void);
>  extern void cfs_bandwidth_usage_dec(void);

These would then go away.

  reply	other threads:[~2021-07-15 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  8:38 [PATCH -next] sched: Dec __cfs_bandwith_used in destroy_cfs_bandwidth() Zhang Qiao
2021-07-12 16:26 ` Daniel Jordan
2021-07-15 11:24 ` [PATCH -next v2] sched: Dec cfs_bandwith_used " Zhang Qiao
2021-07-15 20:28   ` Daniel Jordan [this message]
2021-07-16  2:27 ` [PATCH -next v3] sched: Dec cfs_bandwidth_used " Zhang Qiao
2021-07-16 13:53   ` Daniel Jordan
2021-08-31 11:17   ` Zhang Qiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715202853.no4f7zylvwc5etfu@oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=zhangqiao22@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).