From: Herbert Xu <herbert@gondor.apana.org.au>
To: iLifetruth <yixiaonn@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiang Liu <cyruscyliu@gmail.com>,
yajin@vm-kernel.org
Subject: Re: crypto: prefix additional module autoloading with "crypto-"
Date: Fri, 16 Jul 2021 15:38:18 +0800 [thread overview]
Message-ID: <20210716073818.GA7773@gondor.apana.org.au> (raw)
In-Reply-To: <CABv53a8jyUXns9yu3xyd71_R+nNerU+Xj4i7a4rcZUH0bd52kw@mail.gmail.com>
On Thu, Jul 08, 2021 at 12:33:47PM +0800, iLifetruth wrote:
>
> =========
> And the common fix pattern we found in each crypto-related module is as follows:
> 1. linux/drivers/crypto/padlock-aes.c
> -MODULE_ALIAS("aes");
> +MODULE_ALIAS_CRYPTO("aes");
This is already fixed in the current kernel.
> or in another module:
>
> 2. linux/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> -MODULE_ALIAS("intel_qat");
> +MODULE_ALIAS_CRYPTO("intel_qat");
This is not a bug. The _CRYPTO suffix only applies to the ones
that are algorithm names. intel_qat is not the name of an algorithm.
> ==========
> Even though commit 5d26a105b5a7 added those aliases for a large number
> of modules, it is still missing some newly added crypto-related
> modules.
> For example:
> 1. for file linux/drivers/crypto/amcc/crypto4xx_trng.c in line 129,
> Module_ALIAS is used instead of MODULE_ALIAS_CRYPTO
> MODULE_ALIAS("ppc4xx_rng");
> In fact, ppc4xx-rng was integrated into crypto4xx on 2016-04-18
> by commit 5343e674f32fb8, which was committed about 2 years later than
> the security bug fixing patch(5d26a105b5a7) committed on 2014-11-24
>
> More modules that may not have been fixed are as follows:
> 2. linux/crypto/crypto_user_base.c
> MODULE_ALIAS("net-pf-16-proto-21");
> 3. linux/drivers/crypto/mxs-dcp.c
> MODULE_ALIAS("platform:mxs-dcp");
> 4. linux/drivers/crypto/omap-sham.c
> MODULE_ALIAS("platform:omap-sham");
> 5. linux/drivers/crypto/qcom-rng.c
> MODULE_ALIAS("platform:" KBUILD_MODNAME);
> 6. linux/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
> MODULE_ALIAS("platform:sun4i-ss");
> 7. linux/drivers/crypto/marvell/cesa/cesa.c
> MODULE_ALIAS("platform:mv_crypto");
> 8. linux/drivers/crypto/qce/core.c
> MODULE_ALIAS("platform:" KBUILD_MODNAME);
Nor are any of these algorithm names.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-07-16 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 4:33 crypto: prefix additional module autoloading with "crypto-" iLifetruth
2021-07-16 7:38 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716073818.GA7773@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=cyruscyliu@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yajin@vm-kernel.org \
--cc=yixiaonn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).