Hi, On Mon, May 31, 2021 at 11:39:50AM +0800, Gene Chen wrote: > > > +static int mt6360_charger_remove(struct platform_device *pdev) > > > +{ > > > + struct mt6360_chg_info *mci = platform_get_drvdata(pdev); > > > + > > > + cancel_work_sync(&mci->chrdet_work); > > > + > > > + return 0; > > > +} > > > > Just as a note, devm_work_autocancel() should hopefully be included at > > next cycle. Then you might be able to drop the .remove(). > > ACK, I will replace it, thanks. > > FWIW: > > Reviewed-by: Matti Vaittinen Did I miss a newer revision? -- Sebastian