From: "Ivan T. Ivanov" <iivanov@suse.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: phy: leds: Trigger leds only if PHY speed is known
Date: Fri, 16 Jul 2021 17:11:42 +0300 [thread overview]
Message-ID: <20210716141142.12710-1-iivanov@suse.de> (raw)
This prevents "No phy led trigger registered for speed(-1)"
alert message which is coused by phy_led_trigger_chage_speed()
being called during attaching phy to net_device where phy device
speed could be still unknown.
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
drivers/net/phy/phy_led_triggers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_led_triggers.c b/drivers/net/phy/phy_led_triggers.c
index f550576eb9da..4d6497c45ae4 100644
--- a/drivers/net/phy/phy_led_triggers.c
+++ b/drivers/net/phy/phy_led_triggers.c
@@ -33,7 +33,7 @@ void phy_led_trigger_change_speed(struct phy_device *phy)
if (!phy->link)
return phy_led_trigger_no_link(phy);
- if (phy->speed == 0)
+ if (phy->speed == 0 || phy->speed == SPEED_UNKNOWN)
return;
plt = phy_speed_to_led_trigger(phy, phy->speed);
--
2.32.0
next reply other threads:[~2021-07-16 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 14:11 Ivan T. Ivanov [this message]
2021-07-16 15:19 ` [PATCH] net: phy: leds: Trigger leds only if PHY speed is known Andrew Lunn
[not found] ` <162646032060.16633.4902744414139431224@localhost>
2021-07-19 15:29 ` Russell King (Oracle)
[not found] ` <162737250593.8289.392757192031571742@localhost>
[not found] ` <162806599009.5748.14837844278631256325@localhost>
2021-08-09 14:16 ` Russell King (Oracle)
[not found] ` <162867546407.30043.9226294532918992883@localhost>
2021-08-11 14:39 ` Andrew Lunn
2021-08-11 15:10 ` Russell King (Oracle)
2021-08-11 22:23 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716141142.12710-1-iivanov@suse.de \
--to=iivanov@suse.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).