From: Rob Herring <robh@kernel.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com,
chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com,
ot_jieyang@mediatek.com, drinkcat@chromium.org,
Rex-BC.Chen@mediatek.com, Krzysztof Wilczyski <kw@linux.com>,
Ryan-JH.Yu@mediatek.com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add property to disable dvfsrc voltage request
Date: Fri, 16 Jul 2021 11:33:33 -0600 [thread overview]
Message-ID: <20210716173333.GA3632722@robh.at.kernel.org> (raw)
In-Reply-To: <20210630024934.18903-2-jianjun.wang@mediatek.com>
On Wed, Jun 30, 2021 at 10:49:33AM +0800, Jianjun Wang wrote:
> Add property to disable dvfsrc voltage request, if this property
> is presented, we assume that the requested voltage is always
> higher enough to keep the PCIe controller active.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index e7b1f9892da4..3e26c032cea9 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -96,6 +96,12 @@ properties:
> phys:
> maxItems: 1
>
> + disable-dvfsrc-vlt-req:
> + description: Disable dvfsrc voltage request, if this property is presented,
> + we assume that the requested voltage is always higher enough to keep
> + the PCIe controller active.
> + type: boolean
What determines setting this property? Can it be implied by the
compatible (which should be SoC specific).
Is this property specific to PCIe controller?
Wouldn't the request be harmless to make the voltage request even if not
needed?
I think this probably should be addressed in a common way as part of
other QoS, devfreq, etc. requirements for devices.
Rob
next prev parent reply other threads:[~2021-07-16 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 2:49 [PATCH v3 0/2] PCI: mediatek-gen3: Add support for disable dvfsrc Jianjun Wang
2021-06-30 2:49 ` [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add property to disable dvfsrc voltage request Jianjun Wang
2021-06-30 3:40 ` Qizhong Cheng
2021-07-14 11:20 ` Jianjun Wang
2021-07-16 17:33 ` Rob Herring [this message]
2021-08-19 3:40 ` Jianjun Wang (王建军)
2021-06-30 2:49 ` [PATCH v3 2/2] PCI: mediatek-gen3: Add support for " Jianjun Wang
2021-06-30 3:38 ` Qizhong Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716173333.GA3632722@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Rex-BC.Chen@mediatek.com \
--cc=Ryan-JH.Yu@mediatek.com \
--cc=bhelgaas@google.com \
--cc=chuanjia.liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ot_jieyang@mediatek.com \
--cc=qizhong.cheng@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).