From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Richard Guy Briggs <rgb@redhat.com>,
Paul Moore <paul@paul-moore.com>,
syzbot <syzkaller@googlegroups.com>,
kernel test robot <lkp@intel.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] audit: fix memory leak in nf_tables_commit
Date: Sat, 17 Jul 2021 02:22:43 +0200 [thread overview]
Message-ID: <20210717002243.GA27401@salvia> (raw)
In-Reply-To: <20210714032703.505023-1-mudongliangabcd@gmail.com>
On Wed, Jul 14, 2021 at 11:27:03AM +0800, Dongliang Mu wrote:
> In nf_tables_commit, if nf_tables_commit_audit_alloc fails, it does not
> free the adp variable.
>
> Fix this by adding nf_tables_commit_audit_free which frees
> the linked list with the head node adl.
>
> backtrace:
> kmalloc include/linux/slab.h:591 [inline]
> kzalloc include/linux/slab.h:721 [inline]
> nf_tables_commit_audit_alloc net/netfilter/nf_tables_api.c:8439 [inline]
> nf_tables_commit+0x16e/0x1760 net/netfilter/nf_tables_api.c:8508
> nfnetlink_rcv_batch+0x512/0xa80 net/netfilter/nfnetlink.c:562
> nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:634 [inline]
> nfnetlink_rcv+0x1fa/0x220 net/netfilter/nfnetlink.c:652
> netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline]
> netlink_unicast+0x2c7/0x3e0 net/netlink/af_netlink.c:1340
> netlink_sendmsg+0x36b/0x6b0 net/netlink/af_netlink.c:1929
> sock_sendmsg_nosec net/socket.c:702 [inline]
> sock_sendmsg+0x56/0x80 net/socket.c:722
Applied, thanks.
prev parent reply other threads:[~2021-07-17 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 3:27 [PATCH v3] audit: fix memory leak in nf_tables_commit Dongliang Mu
2021-07-17 0:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717002243.GA27401@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mudongliangabcd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).